From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org,
"Christoph Miebach" <christoph.miebach@web.de>,
"Jeff King" <peff@peff.net>, "Jürgen Rühle" <j-r@online.de>
Subject: Re: [PATCH] send-email: improve RFC2047 quote parsing
Date: Mon, 30 Jul 2012 14:05:09 -0700 [thread overview]
Message-ID: <7vzk6hot8a.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <cb7aa2a8fc08df4f1d12add603ffcbc104f67823.1343676034.git.trast@student.ethz.ch> (Thomas Rast's message of "Mon, 30 Jul 2012 21:25:40 +0200")
Thomas Rast <trast@student.ethz.ch> writes:
> The RFC2047 unquoting, used to parse email addresses in From and Cc
> headers, is broken in several ways:
>
> * It erroneously substitutes ' ' for '_' in *the whole* header, even
> outside the quoted field. [Noticed by Christoph.]
>
> * It is too liberal in its matching, and happily matches the start of
> one quoted chunk against the end of another, or even just something
> that looks like such an end. [Noticed by Junio.]
>
> * It fundamentally cannot cope with encodings that are not a superset
> of ASCII, nor several (incompatible) encodings in the same header.
>
> This patch fixes the first two by doing a more careful decoding of the
> =AB outer quoting. Fixing the fundamental issues is left for a
> future, more intrusive, patch.
What is this =AB thing?
>
> Noticed-by: Christoph Miebach <christoph.miebach@web.de>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
>
> This is the easy part, fixed as per Junio's comment that it needs to
> use a .*? match for the contents, and with a test.
What's the hard part? Do you mean the "fundamentally cannot" part?
Thanks.
> git-send-email.perl | 10 ++++++----
> t/t9001-send-email.sh | 13 +++++++++++++
> 2 files changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index ef30c55..6647137 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -862,11 +862,13 @@ sub make_message_id {
> sub unquote_rfc2047 {
> local ($_) = @_;
> my $encoding;
> - if (s/=\?([^?]+)\?q\?(.*)\?=/$2/g) {
> + s{=\?([^?]+)\?q\?(.*?)\?=}{
> $encoding = $1;
> - s/_/ /g;
> - s/=([0-9A-F]{2})/chr(hex($1))/eg;
> - }
> + my $e = $2;
> + $e =~ s/_/ /g;
> + $e =~ s/=([0-9A-F]{2})/chr(hex($1))/eg;
> + $e;
> + }eg;
> return wantarray ? ($_, $encoding) : $_;
> }
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 8c12c65..0351228 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -841,6 +841,19 @@ test_expect_success $PREREQ '--compose adds MIME for utf8 subject' '
> grep "^Subject: =?UTF-8?q?utf8-s=C3=BCbj=C3=ABct?=" msgtxt1
> '
>
> +test_expect_success $PREREQ 'utf8 author is correctly passed on' '
> + clean_fake_sendmail &&
> + test_commit weird_author &&
> + test_when_finished "git reset --hard HEAD^" &&
> + git commit --amend --author "Füñný Nâmé <odd_?=mail@example.com>" &&
> + git format-patch --stdout -1 >funny_name.patch &&
> + git send-email --from="Example <nobody@example.com>" \
> + --to=nobody@example.com \
> + --smtp-server="$(pwd)/fake.sendmail" \
> + funny_name.patch &&
> + grep "^From: Füñný Nâmé <odd_?=mail@example.com>" msgtxt1
> +'
> +
> test_expect_success $PREREQ 'detects ambiguous reference/file conflict' '
> echo master > master &&
> git add master &&
next prev parent reply other threads:[~2012-07-30 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 19:25 [PATCH] send-email: improve RFC2047 quote parsing Thomas Rast
2012-07-30 21:05 ` Junio C Hamano [this message]
2012-07-31 8:09 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzk6hot8a.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=christoph.miebach@web.de \
--cc=git@vger.kernel.org \
--cc=j-r@online.de \
--cc=peff@peff.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).