git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org, j sixt <j.sixt@viscovery.net>
Subject: Re: [PATCH v2] Make git selectively and conditionally ignore certain stat fields
Date: Mon, 14 Jan 2013 16:11:38 -0800	[thread overview]
Message-ID: <7vy5fv71ad.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1815551092.2039693.1358207014937.JavaMail.root@dewire.com> (Robin Rosenberg's message of "Tue, 15 Jan 2013 00:43:34 +0100 (CET)")

Robin Rosenberg <robin.rosenberg@dewire.com> writes:

> Semantically they're somewhat different. My flags are for ignoring
> a value when it's not used as indicated by the value zero, while
> trustctime is for ignoring untrustworthy, non-zero, values.

Yeah, I realized that after writing that message.

> Another thing that I noticed, is that I probably wanto to be able to filter on the precision
> of timestamps. Again, this i JGit-related. Current JGit has milliseconds precision (max), whereas
> Git has down to nanosecond precision in timestamps. Newer JGits may get nanoseconds timestamps too,
> but on current Linux versions JGit gets only integral seconds regardless of file system. 
>
> Would the names, milli, micro, nano be good for ignoring the tail when zero, or n1..n9 (obviously
> n2 would be ok too). nN = ignore all but first N nsec digits if they are zero)?

It somehow starts to sound like over-engineering to solve a wrong
problem.

I'd say a simplistic "ignore if zero is stored" or even "ignore this
as one of the systems that shares this file writes crap in it" may
be sufficient, and if this is a jGit specific issue, it might even
make sense to introduce a single configuration variable with string
"jgit" somewhere in its name and bypass the stat field comparison
for known-problematic fields, instead of having the user know and
list what stat fields need special attention.

Is this "the user edits in eclipse and then runs 'git status' from the
terminal" problem?

  reply	other threads:[~2013-01-15  0:13 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-05 21:20 [PATCH] Perform minimal stat comparison when some stat fields are not set Robin Rosenberg
2012-12-05 23:43 ` Junio C Hamano
2012-12-06  1:09   ` Robin Rosenberg
2012-12-06  7:21     ` Johannes Sixt
2012-12-06 11:16       ` Robin Rosenberg
2013-01-14 21:11       ` [PATCH v2] Make git selectively and conditionally ignore certain stat fields Robin Rosenberg
2013-01-14 21:57         ` Junio C Hamano
2013-01-14 23:43           ` Robin Rosenberg
2013-01-15  0:11             ` Junio C Hamano [this message]
2013-01-15  0:43               ` Robin Rosenberg
2013-01-15  7:02               ` Johannes Sixt
2013-01-15  7:09               ` Robin Rosenberg
2013-01-15  8:12                 ` Junio C Hamano
2013-01-16 20:14                   ` Ramsay Jones
2013-01-20 19:51                   ` Robin Rosenberg
2013-01-20 20:30                     ` Junio C Hamano
2013-01-22  7:49                       ` [PATCH v3] Enable minimal stat checking Robin Rosenberg
2013-01-22  8:25                         ` Johannes Sixt
2013-01-22 17:19                         ` Torsten Bögershausen
2013-01-22 17:21                         ` Junio C Hamano
2013-01-22 20:38                           ` Robin Rosenberg
2013-05-06 23:22                         ` Jeff King
2013-05-07  4:54                           ` Junio C Hamano
2013-05-07  5:31                             ` [PATCH] deprecate core.statinfo at Git 2.0 boundary Junio C Hamano
2013-05-07  6:38                               ` Junio C Hamano
2013-05-07 14:09                               ` Jeff King
2013-05-07 20:29                                 ` Robin Rosenberg
2013-01-14 23:51           ` [PATCH v3] Make git selectively and conditionally ignore certain stat fields Robin Rosenberg
2013-01-14 22:08         ` [PATCH v2] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vy5fv71ad.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j.sixt@viscovery.net \
    --cc=robin.rosenberg@dewire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).