From: "Torsten Bögershausen" <tboegi@web.de>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"j sixt" <j.sixt@viscovery.net>,
"Shawn Pearce" <spearce@spearce.org>,
"Torsten Bögershausen" <tboegi@web.de>
Subject: Re: [PATCH v3] Enable minimal stat checking
Date: Tue, 22 Jan 2013 18:19:16 +0100 [thread overview]
Message-ID: <50FECA14.5030802@web.de> (raw)
In-Reply-To: <1358840962-12316-1-git-send-email-robin.rosenberg@dewire.com>
+core.checkstat::
+ Determines which stat fields to match between the index
+ and work tree. The user can set this to 'default' or
+ 'minimal'. Default (or explicitly 'default'), is to check
+ all fields, including the sub-second part of mtime and ctime.
+
Setting 'minimal' implies core.trustctime = false
[snip]
> - if (trust_ctime && ce->ce_ctime.sec != (unsigned int)st->st_ctime)
> - changed |= CTIME_CHANGED;
> + if (trust_ctime ? check_stat : trust_ctime/*false*/)
> + if (ce->ce_ctime.sec != (unsigned int)st->st_ctime)
> + changed |= CTIME_CHANGED;
Could that be written as:
+ if (trust_ctime && check_stat && (ce->ce_ctime.sec != (unsigned int)st->st_ctime))
+ changed |= CTIME_CHANGED;
>
> #ifdef USE_NSEC
> - if (ce->ce_mtime.nsec != ST_MTIME_NSEC(*st))
> + if (check_stat && ce->ce_mtime.nsec != ST_MTIME_NSEC(*st))
> changed |= MTIME_CHANGED;
> - if (trust_ctime && ce->ce_ctime.nsec != ST_CTIME_NSEC(*st))
> - changed |= CTIME_CHANGED;
> + if (trust_ctime ? check_stat : trust_ctime/*false*/)
> + if (ce->ce_ctime.nsec != ST_CTIME_NSEC(*st))
> + changed |= CTIME_CHANGED;
And here:
+ if (trust_ctime && check_stat && (ce->ce_ctime.nsec != ST_CTIME_NSEC(*st))
+ changed |= CTIME_CHANGED;
next prev parent reply other threads:[~2013-01-22 17:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 21:20 [PATCH] Perform minimal stat comparison when some stat fields are not set Robin Rosenberg
2012-12-05 23:43 ` Junio C Hamano
2012-12-06 1:09 ` Robin Rosenberg
2012-12-06 7:21 ` Johannes Sixt
2012-12-06 11:16 ` Robin Rosenberg
2013-01-14 21:11 ` [PATCH v2] Make git selectively and conditionally ignore certain stat fields Robin Rosenberg
2013-01-14 21:57 ` Junio C Hamano
2013-01-14 23:43 ` Robin Rosenberg
2013-01-15 0:11 ` Junio C Hamano
2013-01-15 0:43 ` Robin Rosenberg
2013-01-15 7:02 ` Johannes Sixt
2013-01-15 7:09 ` Robin Rosenberg
2013-01-15 8:12 ` Junio C Hamano
2013-01-16 20:14 ` Ramsay Jones
2013-01-20 19:51 ` Robin Rosenberg
2013-01-20 20:30 ` Junio C Hamano
2013-01-22 7:49 ` [PATCH v3] Enable minimal stat checking Robin Rosenberg
2013-01-22 8:25 ` Johannes Sixt
2013-01-22 17:19 ` Torsten Bögershausen [this message]
2013-01-22 17:21 ` Junio C Hamano
2013-01-22 20:38 ` Robin Rosenberg
2013-05-06 23:22 ` Jeff King
2013-05-07 4:54 ` Junio C Hamano
2013-05-07 5:31 ` [PATCH] deprecate core.statinfo at Git 2.0 boundary Junio C Hamano
2013-05-07 6:38 ` Junio C Hamano
2013-05-07 14:09 ` Jeff King
2013-05-07 20:29 ` Robin Rosenberg
2013-01-14 23:51 ` [PATCH v3] Make git selectively and conditionally ignore certain stat fields Robin Rosenberg
2013-01-14 22:08 ` [PATCH v2] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FECA14.5030802@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=robin.rosenberg@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).