From: Junio C Hamano <gitster@pobox.com>
To: "Célestin Matte" <celestin.matte@ensimag.fr>
Cc: git@vger.kernel.org, benoit.person@ensimag.fr,
matthieu.moy@grenoble-inp.fr
Subject: Re: [PATCH v6 00/31] git-remote-mediawiki: Follow perlcritic's recommandations
Date: Fri, 14 Jun 2013 09:03:48 -0700 [thread overview]
Message-ID: <7vwqpwptln.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1371217839-23017-1-git-send-email-celestin.matte@ensimag.fr> ("Célestin Matte"'s message of "Fri, 14 Jun 2013 15:50:08 +0200")
Célestin Matte <celestin.matte@ensimag.fr> writes:
> Célestin Matte (31):
> git-remote-mediawiki: Make a regexp clearer
> git-remote-mediawiki: Move "use warnings;" before any instruction
> git-remote-mediawiki: Replace :utf8 by :encoding(UTF-8)
> git-remote-mediawiki: Always end a subroutine with a return
> git-remote-mediawiki: Move a variable declaration at the top of the
> code
> git-remote-mediawiki: Change syntax of map calls
> git-remote-mediawiki: Rewrite unclear line of instructions
> git-remote-mediawiki: Remove useless regexp modifier (m)
> git-remote-mediawiki: Change the behaviour of a split
> git-remote-mediawiki: Change separator of some regexps
> git-remote-mediawiki: Change style in a regexp
> git-remote-mediawiki: Change style in a regexp
> git-remote-mediawiki: Add newline in the end of die() error messages
> git-remote-mediawiki: Change the name of a variable
> git-remote-mediawiki: Turn double-negated expressions into simple
> expressions
> git-remote-mediawiki: Remove unused variable $entry
> git-remote-mediawiki: Rename a variable ($last) which has the name of
> a keyword
> git-remote-mediawiki: Assign a variable as undef and make proper
> indentation
> git-remote-mediawiki: Check return value of open
> git-remote-mediawiki: remove import of unused open2
> git-remote-mediawiki: Put long code into a subroutine
> git-remote-mediawiki: Modify strings for a better coding-style
> git-remote-mediawiki: Brace file handles for print for more clarity
> git-remote-mediawiki: Replace "unless" statements with negated "if"
> statements
> git-remote-mediawiki: Don't use quotes for empty strings
> git-remote-mediawiki: Put non-trivial numeric values in constants.
> git-remote-mediawiki: Fix a typo ("mediwiki" instead of "mediawiki")
> git-remote-mediawiki: Clearly rewrite double dereference
> git-remote-mediawiki: Add a .perlcriticrc file
> git-remote-mediawiki: add a perlcritic rule in Makefile
> git-remote-mediawiki: Make error message more precise
>
> contrib/mw-to-git/.perlcriticrc | 28 ++
> contrib/mw-to-git/Makefile | 2 +
> contrib/mw-to-git/git-remote-mediawiki.perl | 537 +++++++++++++++-------------
> 3 files changed, 320 insertions(+), 247 deletions(-)
> create mode 100644 contrib/mw-to-git/.perlcriticrc
Thanks. Will queue.
prev parent reply other threads:[~2013-06-14 16:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 13:50 [PATCH v6 00/31] git-remote-mediawiki: Follow perlcritic's recommandations Célestin Matte
2013-06-14 13:50 ` [PATCH v6 01/31] git-remote-mediawiki: Make a regexp clearer Célestin Matte
2013-06-14 13:50 ` [PATCH v6 02/31] git-remote-mediawiki: Move "use warnings;" before any instruction Célestin Matte
2013-06-14 13:50 ` [PATCH v6 03/31] git-remote-mediawiki: Replace :utf8 by :encoding(UTF-8) Célestin Matte
2013-06-14 13:50 ` [PATCH v6 04/31] git-remote-mediawiki: Always end a subroutine with a return Célestin Matte
2013-06-14 13:50 ` [PATCH v6 05/31] git-remote-mediawiki: Move a variable declaration at the top of the code Célestin Matte
2013-06-14 13:50 ` [PATCH v6 06/31] git-remote-mediawiki: Change syntax of map calls Célestin Matte
2013-06-14 13:50 ` [PATCH v6 07/31] git-remote-mediawiki: Rewrite unclear line of instructions Célestin Matte
2013-06-14 13:50 ` [PATCH v6 08/31] git-remote-mediawiki: Remove useless regexp modifier (m) Célestin Matte
2013-06-14 13:50 ` [PATCH v6 09/31] git-remote-mediawiki: Change the behaviour of a split Célestin Matte
2013-06-14 13:50 ` [PATCH v6 10/31] git-remote-mediawiki: Change separator of some regexps Célestin Matte
2013-06-14 13:50 ` [PATCH v6 11/31] git-remote-mediawiki: Change style in a regexp Célestin Matte
2013-06-14 13:50 ` [PATCH v6 12/31] " Célestin Matte
2013-06-14 13:50 ` [PATCH v6 13/31] git-remote-mediawiki: Add newline in the end of die() error messages Célestin Matte
2013-06-14 13:50 ` [PATCH v6 14/31] git-remote-mediawiki: Change the name of a variable Célestin Matte
2013-06-14 13:50 ` [PATCH v6 15/31] git-remote-mediawiki: Turn double-negated expressions into simple expressions Célestin Matte
2013-06-14 13:50 ` [PATCH v6 16/31] git-remote-mediawiki: Remove unused variable $entry Célestin Matte
2013-06-14 13:50 ` [PATCH v6 17/31] git-remote-mediawiki: Rename a variable ($last) which has the name of a keyword Célestin Matte
2013-06-14 13:50 ` [PATCH v6 18/31] git-remote-mediawiki: Assign a variable as undef and make proper indentation Célestin Matte
2013-06-14 13:50 ` [PATCH v6 19/31] git-remote-mediawiki: Check return value of open Célestin Matte
2013-06-14 13:50 ` [PATCH v6 20/31] git-remote-mediawiki: remove import of unused open2 Célestin Matte
2013-06-14 13:50 ` [PATCH v6 21/31] git-remote-mediawiki: Put long code into a subroutine Célestin Matte
2013-06-14 13:50 ` [PATCH v6 22/31] git-remote-mediawiki: Modify strings for a better coding-style Célestin Matte
2013-06-14 13:50 ` [PATCH v6 23/31] git-remote-mediawiki: Brace file handles for print for more clarity Célestin Matte
2013-06-14 13:50 ` [PATCH v6 24/31] git-remote-mediawiki: Replace "unless" statements with negated "if" statements Célestin Matte
2013-06-14 13:50 ` [PATCH v6 25/31] git-remote-mediawiki: Don't use quotes for empty strings Célestin Matte
2013-06-14 13:50 ` [PATCH v6 26/31] git-remote-mediawiki: Put non-trivial numeric values in constants Célestin Matte
2013-06-14 13:50 ` [PATCH v6 27/31] git-remote-mediawiki: Fix a typo ("mediwiki" instead of "mediawiki") Célestin Matte
2013-06-14 13:50 ` [PATCH v6 28/31] git-remote-mediawiki: Clearly rewrite double dereference Célestin Matte
2013-06-14 13:50 ` [PATCH v6 29/31] git-remote-mediawiki: Add a .perlcriticrc file Célestin Matte
2013-06-14 13:50 ` [PATCH v6 30/31] git-remote-mediawiki: add a perlcritic rule in Makefile Célestin Matte
2013-06-14 13:50 ` [PATCH v6 31/31] git-remote-mediawiki: Make error message more precise Célestin Matte
2013-06-14 16:03 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwqpwptln.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=benoit.person@ensimag.fr \
--cc=celestin.matte@ensimag.fr \
--cc=git@vger.kernel.org \
--cc=matthieu.moy@grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).