git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Célestin Matte" <celestin.matte@ensimag.fr>
To: git@vger.kernel.org
Cc: benoit.person@ensimag.fr, matthieu.moy@grenoble-inp.fr,
	"Célestin Matte" <celestin.matte@ensimag.fr>
Subject: [PATCH v6 24/31] git-remote-mediawiki: Replace "unless" statements with negated "if" statements
Date: Fri, 14 Jun 2013 15:50:32 +0200	[thread overview]
Message-ID: <1371217839-23017-25-git-send-email-celestin.matte@ensimag.fr> (raw)
In-Reply-To: <1371217839-23017-1-git-send-email-celestin.matte@ensimag.fr>

From: Célestin Matte <celestin.matte@ensimag.fr>

Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr>
Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
---
 contrib/mw-to-git/git-remote-mediawiki.perl | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
index 9e828ab..f0c313f 100755
--- a/contrib/mw-to-git/git-remote-mediawiki.perl
+++ b/contrib/mw-to-git/git-remote-mediawiki.perl
@@ -82,11 +82,11 @@ $shallow_import = ($shallow_import eq 'true');
 # - by_rev: perform one query per new revision on the remote wiki
 # - by_page: query each tracked page for new revision
 my $fetch_strategy = run_git("config --get remote.${remotename}.fetchStrategy");
-unless ($fetch_strategy) {
+if (!$fetch_strategy) {
 	$fetch_strategy = run_git('config --get mediawiki.fetchStrategy');
 }
 chomp($fetch_strategy);
-unless ($fetch_strategy) {
+if (!$fetch_strategy) {
 	$fetch_strategy = 'by_page';
 }
 
@@ -108,7 +108,7 @@ my %basetimestamps;
 # deterministic, this means everybody gets the same sha1 for each
 # MediaWiki revision.
 my $dumb_push = run_git("config --get --bool remote.${remotename}.dumbPush");
-unless ($dumb_push) {
+if (!$dumb_push) {
 	$dumb_push = run_git('config --get --bool mediawiki.dumbPush');
 }
 chomp($dumb_push);
@@ -667,7 +667,7 @@ sub fetch_mw_revisions_for_page {
 			push(@page_revs, $page_rev_ids);
 			$revnum++;
 		}
-		last unless $result->{'query-continue'};
+		last if (!$result->{'query-continue'});
 		$query->{rvstartid} = $result->{'query-continue'}->{revisions}->{rvstartid};
 	}
 	if ($shallow_import && @page_revs) {
@@ -1239,7 +1239,7 @@ sub mw_push_revision {
 				die("Unknown error from mw_push_file()\n");
 			}
 		}
-		unless ($dumb_push) {
+		if (!$dumb_push) {
 			run_git(qq(notes --ref=${remotename}/mediawiki add -f -m "mediawiki_revision: ${mw_revision}" ${sha1_commit}));
 			run_git(qq(update-ref -m "Git-MediaWiki push" refs/mediawiki/${remotename}/master ${sha1_commit} ${sha1_child}));
 		}
@@ -1320,7 +1320,7 @@ sub get_mw_namespace_id {
 	my $ns = $namespace_id{$name};
 	my $id;
 
-	unless (defined $ns) {
+	if (!defined $ns) {
 		print {*STDERR} "No such namespace ${name} on MediaWiki.\n";
 		$ns = {is_namespace => 0};
 		$namespace_id{$name} = $ns;
-- 
1.8.3.rc3.49.g4e74807

  parent reply	other threads:[~2013-06-14 13:52 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 13:50 [PATCH v6 00/31] git-remote-mediawiki: Follow perlcritic's recommandations Célestin Matte
2013-06-14 13:50 ` [PATCH v6 01/31] git-remote-mediawiki: Make a regexp clearer Célestin Matte
2013-06-14 13:50 ` [PATCH v6 02/31] git-remote-mediawiki: Move "use warnings;" before any instruction Célestin Matte
2013-06-14 13:50 ` [PATCH v6 03/31] git-remote-mediawiki: Replace :utf8 by :encoding(UTF-8) Célestin Matte
2013-06-14 13:50 ` [PATCH v6 04/31] git-remote-mediawiki: Always end a subroutine with a return Célestin Matte
2013-06-14 13:50 ` [PATCH v6 05/31] git-remote-mediawiki: Move a variable declaration at the top of the code Célestin Matte
2013-06-14 13:50 ` [PATCH v6 06/31] git-remote-mediawiki: Change syntax of map calls Célestin Matte
2013-06-14 13:50 ` [PATCH v6 07/31] git-remote-mediawiki: Rewrite unclear line of instructions Célestin Matte
2013-06-14 13:50 ` [PATCH v6 08/31] git-remote-mediawiki: Remove useless regexp modifier (m) Célestin Matte
2013-06-14 13:50 ` [PATCH v6 09/31] git-remote-mediawiki: Change the behaviour of a split Célestin Matte
2013-06-14 13:50 ` [PATCH v6 10/31] git-remote-mediawiki: Change separator of some regexps Célestin Matte
2013-06-14 13:50 ` [PATCH v6 11/31] git-remote-mediawiki: Change style in a regexp Célestin Matte
2013-06-14 13:50 ` [PATCH v6 12/31] " Célestin Matte
2013-06-14 13:50 ` [PATCH v6 13/31] git-remote-mediawiki: Add newline in the end of die() error messages Célestin Matte
2013-06-14 13:50 ` [PATCH v6 14/31] git-remote-mediawiki: Change the name of a variable Célestin Matte
2013-06-14 13:50 ` [PATCH v6 15/31] git-remote-mediawiki: Turn double-negated expressions into simple expressions Célestin Matte
2013-06-14 13:50 ` [PATCH v6 16/31] git-remote-mediawiki: Remove unused variable $entry Célestin Matte
2013-06-14 13:50 ` [PATCH v6 17/31] git-remote-mediawiki: Rename a variable ($last) which has the name of a keyword Célestin Matte
2013-06-14 13:50 ` [PATCH v6 18/31] git-remote-mediawiki: Assign a variable as undef and make proper indentation Célestin Matte
2013-06-14 13:50 ` [PATCH v6 19/31] git-remote-mediawiki: Check return value of open Célestin Matte
2013-06-14 13:50 ` [PATCH v6 20/31] git-remote-mediawiki: remove import of unused open2 Célestin Matte
2013-06-14 13:50 ` [PATCH v6 21/31] git-remote-mediawiki: Put long code into a subroutine Célestin Matte
2013-06-14 13:50 ` [PATCH v6 22/31] git-remote-mediawiki: Modify strings for a better coding-style Célestin Matte
2013-06-14 13:50 ` [PATCH v6 23/31] git-remote-mediawiki: Brace file handles for print for more clarity Célestin Matte
2013-06-14 13:50 ` Célestin Matte [this message]
2013-06-14 13:50 ` [PATCH v6 25/31] git-remote-mediawiki: Don't use quotes for empty strings Célestin Matte
2013-06-14 13:50 ` [PATCH v6 26/31] git-remote-mediawiki: Put non-trivial numeric values in constants Célestin Matte
2013-06-14 13:50 ` [PATCH v6 27/31] git-remote-mediawiki: Fix a typo ("mediwiki" instead of "mediawiki") Célestin Matte
2013-06-14 13:50 ` [PATCH v6 28/31] git-remote-mediawiki: Clearly rewrite double dereference Célestin Matte
2013-06-14 13:50 ` [PATCH v6 29/31] git-remote-mediawiki: Add a .perlcriticrc file Célestin Matte
2013-06-14 13:50 ` [PATCH v6 30/31] git-remote-mediawiki: add a perlcritic rule in Makefile Célestin Matte
2013-06-14 13:50 ` [PATCH v6 31/31] git-remote-mediawiki: Make error message more precise Célestin Matte
2013-06-14 16:03 ` [PATCH v6 00/31] git-remote-mediawiki: Follow perlcritic's recommandations Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371217839-23017-25-git-send-email-celestin.matte@ensimag.fr \
    --to=celestin.matte@ensimag.fr \
    --cc=benoit.person@ensimag.fr \
    --cc=git@vger.kernel.org \
    --cc=matthieu.moy@grenoble-inp.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).