* [PATCH] lib-rebase: document exec_ in FAKE_LINES
@ 2013-07-01 16:20 Andrew Pimlott
2013-07-01 16:20 ` [PATCH] t7500: fix flipped actual/expect Andrew Pimlott
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Pimlott @ 2013-07-01 16:20 UTC (permalink / raw)
To: git; +Cc: Andrew Pimlott
Signed-off-by: Andrew Pimlott <andrew@pimlott.net>
---
t/lib-rebase.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/t/lib-rebase.sh b/t/lib-rebase.sh
index cfd3409..7f119e2 100644
--- a/t/lib-rebase.sh
+++ b/t/lib-rebase.sh
@@ -17,6 +17,8 @@
# ("squash", "fixup", "edit", or "reword") and the SHA1 taken
# from the specified line.
#
+# "exec_cmd_with_args" -- add an "exec cmd with args" line.
+#
# "#" -- Add a comment line.
#
# ">" -- Add a blank line.
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] t7500: fix flipped actual/expect
2013-07-01 16:20 [PATCH] lib-rebase: document exec_ in FAKE_LINES Andrew Pimlott
@ 2013-07-01 16:20 ` Andrew Pimlott
2013-07-01 16:52 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Pimlott @ 2013-07-01 16:20 UTC (permalink / raw)
To: git; +Cc: Andrew Pimlott
Signed-off-by: Andrew Pimlott <andrew@pimlott.net>
---
t/t7500-commit.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t7500-commit.sh b/t/t7500-commit.sh
index 436b7b6..e166ac8 100755
--- a/t/t7500-commit.sh
+++ b/t/t7500-commit.sh
@@ -13,8 +13,8 @@ commit_msg_is () {
expect=commit_msg_is.expect
actual=commit_msg_is.actual
- printf "%s" "$(git log --pretty=format:%s%b -1)" >$expect &&
- printf "%s" "$1" >$actual &&
+ printf "%s" "$(git log --pretty=format:%s%b -1)" >$actual &&
+ printf "%s" "$1" >$expect &&
test_i18ncmp $expect $actual
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] t7500: fix flipped actual/expect
2013-07-01 16:20 ` [PATCH] t7500: fix flipped actual/expect Andrew Pimlott
@ 2013-07-01 16:52 ` Junio C Hamano
2013-07-01 17:07 ` Andrew Pimlott
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2013-07-01 16:52 UTC (permalink / raw)
To: Andrew Pimlott; +Cc: git
Andrew Pimlott <andrew@pimlott.net> writes:
> Signed-off-by: Andrew Pimlott <andrew@pimlott.net>
> ---
> t/t7500-commit.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t7500-commit.sh b/t/t7500-commit.sh
> index 436b7b6..e166ac8 100755
> --- a/t/t7500-commit.sh
> +++ b/t/t7500-commit.sh
> @@ -13,8 +13,8 @@ commit_msg_is () {
> expect=commit_msg_is.expect
> actual=commit_msg_is.actual
>
> - printf "%s" "$(git log --pretty=format:%s%b -1)" >$expect &&
> - printf "%s" "$1" >$actual &&
> + printf "%s" "$(git log --pretty=format:%s%b -1)" >$actual &&
> + printf "%s" "$1" >$expect &&
> test_i18ncmp $expect $actual
> }
Wow. How could all of us missed this for a long time?
Thanks, the change obviously looks good.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] t7500: fix flipped actual/expect
2013-07-01 16:52 ` Junio C Hamano
@ 2013-07-01 17:07 ` Andrew Pimlott
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Pimlott @ 2013-07-01 17:07 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Excerpts from Junio C Hamano's message of Mon Jul 01 09:52:05 -0700 2013:
> Wow. How could all of us missed this for a long time?
:-) I don't know, but little is more frustrating than a misleading
diagnostic.
BTW, I didn't expect git-send-email to send those two messages in a
thread. I'll keep them separate next time.
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-01 17:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-01 16:20 [PATCH] lib-rebase: document exec_ in FAKE_LINES Andrew Pimlott
2013-07-01 16:20 ` [PATCH] t7500: fix flipped actual/expect Andrew Pimlott
2013-07-01 16:52 ` Junio C Hamano
2013-07-01 17:07 ` Andrew Pimlott
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).