From: Junio C Hamano <gitster@pobox.com>
To: Benoit SIGOURE <tsuna@lrde.epita.fr>
Cc: Mike Hommey <mh@glandium.org>, git@vger.kernel.org
Subject: Re: commit summary, --pretty=short and other tools
Date: Mon, 17 Sep 2007 17:24:05 -0700 [thread overview]
Message-ID: <7vr6kwyg62.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <55887C88-8523-4839-8B91-236256A5E893@lrde.epita.fr> (Benoit SIGOURE's message of "Tue, 18 Sep 2007 01:52:21 +0200")
Benoit SIGOURE <tsuna@lrde.epita.fr> writes:
> I started using Git as a "better SVN client" and didn't follow this
> "good idea". The thing, as I already pointed out on IRC, these a are
> more rules than just guidelines. Some tools (such as rebase) enforce
> them. That is, they rewrite commit messages. I found this extremely
> annoying (Junio provided a patch but I don't know whether it's been
> applied, I personally use it in my Git).
Wow, ancient history.
d7f6bae28142e07e544efdab73260cf9f60ca899 (rebase: try not to
munge commit log message) is what you are talking about. It is
in 1.5.3.
commit d7f6bae28142e07e544efdab73260cf9f60ca899
Author: Junio C Hamano <gitster@pobox.com>
Date: Sat Jul 28 17:57:25 2007 -0700
rebase: try not to munge commit log message
This makes rebase/am keep the original commit log message
better, even when it does not conform to "single line paragraph
to say what it does, then explain and defend why it is a good
change in later paragraphs" convention.
This change is a two-edged sword. While the earlier behaviour
would make such commit log messages more friendly to readers who
expect to get the birds-eye view with oneline summary formats,
users who primarily use git as a way to interact with foreign
SCM systems would not care much about the convenience of oneline
git log tools, but care more about preserving their own
convention. This changes their commits less useful to readers
who read them with git tools while keeping them more consistent
with the foreign SCM systems they interact with.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
next prev parent reply other threads:[~2007-09-18 0:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 11:21 commit summary, --pretty=short and other tools Mike Hommey
2007-09-17 11:42 ` Jeff King
2007-09-17 23:52 ` Benoit SIGOURE
2007-09-18 0:24 ` Junio C Hamano [this message]
2007-09-18 7:19 ` Andreas Ericsson
2007-09-18 10:13 ` Johannes Schindelin
2007-09-18 10:23 ` Andreas Ericsson
2007-09-18 10:27 ` Benoit SIGOURE
2007-09-18 10:54 ` Johannes Schindelin
2007-09-18 11:43 ` Wincent Colaiuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr6kwyg62.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
--cc=tsuna@lrde.epita.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).