From: Benoit SIGOURE <tsuna@lrde.epita.fr>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org
Subject: Re: commit summary, --pretty=short and other tools
Date: Tue, 18 Sep 2007 01:52:21 +0200 [thread overview]
Message-ID: <55887C88-8523-4839-8B91-236256A5E893@lrde.epita.fr> (raw)
In-Reply-To: <20070917112136.GA30201@glandium.org>
[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]
On Sep 17, 2007, at 1:21 PM, Mike Hommey wrote:
> Hi,
>
> I kind of shot myself in the foot with how to type proper commit
> messages.
>
> The git-commit manual page reads:
> Though not required, it´s a good idea to begin the commit message
> with a
> single short (less than 50 character) line summarizing the change,
> followed by a blank line and then a more thorough description.
>
> ... and I happen to not have done the "followed by a blank line" part.
>
[...]
> What do you think ?
I started using Git as a "better SVN client" and didn't follow this
"good idea". The thing, as I already pointed out on IRC, these a are
more rules than just guidelines. Some tools (such as rebase) enforce
them. That is, they rewrite commit messages. I found this extremely
annoying (Junio provided a patch but I don't know whether it's been
applied, I personally use it in my Git).
See this thread: http://marc.info/?t=118561729500001&r=1&w=2
My opinion is that it would be better to keep the first line and
never ever rewrite the commit messages.
Cheers,
--
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 186 bytes --]
next prev parent reply other threads:[~2007-09-17 23:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 11:21 commit summary, --pretty=short and other tools Mike Hommey
2007-09-17 11:42 ` Jeff King
2007-09-17 23:52 ` Benoit SIGOURE [this message]
2007-09-18 0:24 ` Junio C Hamano
2007-09-18 7:19 ` Andreas Ericsson
2007-09-18 10:13 ` Johannes Schindelin
2007-09-18 10:23 ` Andreas Ericsson
2007-09-18 10:27 ` Benoit SIGOURE
2007-09-18 10:54 ` Johannes Schindelin
2007-09-18 11:43 ` Wincent Colaiuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55887C88-8523-4839-8B91-236256A5E893@lrde.epita.fr \
--to=tsuna@lrde.epita.fr \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).