From: Junio C Hamano <gitster@pobox.com>
To: markus.heidelberg@web.de
Cc: git@vger.kernel.org, Michael Witten <mfwitten@gmail.com>
Subject: Re: [RF sanity check] send-email threading fixes
Date: Thu, 11 Jun 2009 13:38:51 -0700 [thread overview]
Message-ID: <7vprdah5es.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <200906111849.40232.markus.heidelberg@web.de> (Markus Heidelberg's message of "Thu\, 11 Jun 2009 18\:49\:39 +0200")
Markus Heidelberg <markus.heidelberg@web.de> writes:
>> [PATCH 4/6] send-email: fix threaded mails without chain-reply-to
>> [PATCH 5/6] add a test for git-send-email for threaded mails without chain-reply-to
>> [PATCH 6/6] send-email: fix a typo in a comment
>>
>> Patch 4/6 applies on top of 15da108 to fix a breakage introduced by that
>> commit. Together with the result of applying the first three patches to
>> maint, they fix --no-thread and --thread (without --chain-reply-to) cases.
>> The result can be verified by applying Patch 5/6 on top of them.
>
> Out of curiosity: why are 4/6 and 5/6 applied on different branches
> without the usual commits first "test with test_expect_fail" then "fix +
> test changed to test_expect_success"?
Maybe I misunderstood your problem description, but my impression from it
was that 4/6 is a fix to a latent bug in 15da108 that later affected what
was done by new code that appeard somewhere between 15da108 and 'master',
and the test 5/6 was about that breakage. IOW, root cause was older than
the symptom.
next prev parent reply other threads:[~2009-06-11 21:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-07 21:40 [PATCH 0/6] fixes for git-send-email Markus Heidelberg
2009-06-07 21:40 ` [PATCH 1/6] send-email: fix a typo in a comment Markus Heidelberg
2009-06-08 21:44 ` Junio C Hamano
2009-06-09 7:05 ` Markus Heidelberg
2009-06-09 7:11 ` [PATCH 1/2] add a test for git-send-email for non-threaded mails Markus Heidelberg
2009-06-09 7:11 ` [PATCH 2/2] send-email: fix " Markus Heidelberg
2009-06-07 21:40 ` [PATCH 2/6] add a test for git-send-email for threaded mails without chain-reply-to Markus Heidelberg
2009-06-07 23:28 ` Junio C Hamano
2009-06-08 5:47 ` Markus Heidelberg
2009-06-08 6:37 ` [PATCH v2 " Markus Heidelberg
2009-06-08 6:57 ` Junio C Hamano
2009-06-07 21:40 ` [PATCH 3/6] send-email: fix " Markus Heidelberg
2009-06-10 5:51 ` Junio C Hamano
2009-06-10 7:15 ` [RF sanity check] send-email threading fixes (was Re: [PATCH 3/6] send-email: fix threaded mails without chain-reply-to) Junio C Hamano
2009-06-11 16:49 ` Markus Heidelberg
2009-06-11 20:38 ` Junio C Hamano [this message]
2009-06-11 22:49 ` [RF sanity check] send-email threading fixes Markus Heidelberg
2009-06-11 23:21 ` Junio C Hamano
2009-06-12 10:49 ` [PATCH 0/6] " Markus Heidelberg
2009-06-12 10:51 ` [PATCH 1/6] add a test for git-send-email for non-threaded mails Markus Heidelberg
2009-06-12 10:51 ` [PATCH 2/6] send-email: fix " Markus Heidelberg
2009-06-12 10:51 ` [PATCH 3/6] doc/send-email: clarify the behavior of --in-reply-to with --no-thread Markus Heidelberg
2009-06-12 10:51 ` [PATCH 4/6] add a test for git-send-email for threaded mails without chain-reply-to Markus Heidelberg
2009-06-12 10:51 ` [PATCH 5/6] send-email: fix " Markus Heidelberg
2009-06-12 10:51 ` [PATCH 6/6] send-email: fix a typo in a comment Markus Heidelberg
2009-06-10 7:16 ` [PATCH 1/6] add a test for git-send-email for non-threaded mails Junio C Hamano
2009-06-10 7:16 ` [PATCH 2/6] send-email: fix " Junio C Hamano
2009-06-10 7:16 ` [PATCH 3/6] doc/send-email: clarify the behavior of --in-reply-to with --no-thread Junio C Hamano
2009-06-10 7:17 ` [PATCH 4/6] send-email: fix threaded mails without chain-reply-to Junio C Hamano
2009-06-10 7:17 ` [PATCH 5/6] add a test for git-send-email for " Junio C Hamano
2009-06-10 7:17 ` [PATCH 6/6] send-email: fix a typo in a comment Junio C Hamano
2009-06-07 21:40 ` [PATCH 4/6] add a test for git-send-email for non-threaded mails Markus Heidelberg
2009-06-08 6:41 ` [PATCH v2 " Markus Heidelberg
2009-06-08 7:00 ` Junio C Hamano
2009-06-08 7:13 ` [PATCH v3 " Markus Heidelberg
2009-06-07 21:40 ` [PATCH 5/6] send-email: fix " Markus Heidelberg
2009-06-08 6:43 ` [PATCH v2 " Markus Heidelberg
2009-06-07 21:40 ` [PATCH 6/6] doc/send-email: clarify the behavior of --in-reply-to with --no-thread Markus Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vprdah5es.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=markus.heidelberg@web.de \
--cc=mfwitten@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).