git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: markus.heidelberg@web.de
Cc: git@vger.kernel.org, Michael Witten <mfwitten@gmail.com>,
	Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH v2 4/6] add a test for git-send-email for non-threaded mails
Date: Mon, 08 Jun 2009 00:00:44 -0700	[thread overview]
Message-ID: <7vd49f8b1f.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <200906080842.00357.markus.heidelberg@web.de> (Markus Heidelberg's message of "Mon\, 8 Jun 2009 08\:41\:59 +0200")

Markus Heidelberg <markus.heidelberg@web.de> writes:

> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
> ---
>
> Differences to v1:
> * dump stdout into a file and grep this
> * use "test_must_fail grep" instead of "!git send-email"
>   I'm not sure about this. When should test_must_fail be used and when
>   is !command OK?

Thanks.

Generally, we protect "git" (i.e. what we write ourselves) with test_must_fail
so that we can catch stupid segfaulting crash we introduce ourselves
(unlike "! git foo", "test_must_fail git foo" says "oh, no, it did not
correctly fail" if git segfaults).  We do not expect "grep" to segfault
(iow we are not testing "grep"), so it is customary to say "! grep".

  reply	other threads:[~2009-06-08  7:00 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-07 21:40 [PATCH 0/6] fixes for git-send-email Markus Heidelberg
2009-06-07 21:40 ` [PATCH 1/6] send-email: fix a typo in a comment Markus Heidelberg
2009-06-08 21:44   ` Junio C Hamano
2009-06-09  7:05     ` Markus Heidelberg
2009-06-09  7:11       ` [PATCH 1/2] add a test for git-send-email for non-threaded mails Markus Heidelberg
2009-06-09  7:11       ` [PATCH 2/2] send-email: fix " Markus Heidelberg
2009-06-07 21:40 ` [PATCH 2/6] add a test for git-send-email for threaded mails without chain-reply-to Markus Heidelberg
2009-06-07 23:28   ` Junio C Hamano
2009-06-08  5:47     ` Markus Heidelberg
2009-06-08  6:37       ` [PATCH v2 " Markus Heidelberg
2009-06-08  6:57         ` Junio C Hamano
2009-06-07 21:40 ` [PATCH 3/6] send-email: fix " Markus Heidelberg
2009-06-10  5:51   ` Junio C Hamano
2009-06-10  7:15     ` [RF sanity check] send-email threading fixes (was Re: [PATCH 3/6] send-email: fix threaded mails without chain-reply-to) Junio C Hamano
2009-06-11 16:49       ` Markus Heidelberg
2009-06-11 20:38         ` [RF sanity check] send-email threading fixes Junio C Hamano
2009-06-11 22:49           ` Markus Heidelberg
2009-06-11 23:21             ` Junio C Hamano
2009-06-12 10:49               ` [PATCH 0/6] " Markus Heidelberg
2009-06-12 10:51                 ` [PATCH 1/6] add a test for git-send-email for non-threaded mails Markus Heidelberg
2009-06-12 10:51                 ` [PATCH 2/6] send-email: fix " Markus Heidelberg
2009-06-12 10:51                 ` [PATCH 3/6] doc/send-email: clarify the behavior of --in-reply-to with --no-thread Markus Heidelberg
2009-06-12 10:51                 ` [PATCH 4/6] add a test for git-send-email for threaded mails without chain-reply-to Markus Heidelberg
2009-06-12 10:51                 ` [PATCH 5/6] send-email: fix " Markus Heidelberg
2009-06-12 10:51                 ` [PATCH 6/6] send-email: fix a typo in a comment Markus Heidelberg
2009-06-10  7:16     ` [PATCH 1/6] add a test for git-send-email for non-threaded mails Junio C Hamano
2009-06-10  7:16     ` [PATCH 2/6] send-email: fix " Junio C Hamano
2009-06-10  7:16     ` [PATCH 3/6] doc/send-email: clarify the behavior of --in-reply-to with --no-thread Junio C Hamano
2009-06-10  7:17     ` [PATCH 4/6] send-email: fix threaded mails without chain-reply-to Junio C Hamano
2009-06-10  7:17     ` [PATCH 5/6] add a test for git-send-email for " Junio C Hamano
2009-06-10  7:17     ` [PATCH 6/6] send-email: fix a typo in a comment Junio C Hamano
2009-06-07 21:40 ` [PATCH 4/6] add a test for git-send-email for non-threaded mails Markus Heidelberg
2009-06-08  6:41   ` [PATCH v2 " Markus Heidelberg
2009-06-08  7:00     ` Junio C Hamano [this message]
2009-06-08  7:13       ` [PATCH v3 " Markus Heidelberg
2009-06-07 21:40 ` [PATCH 5/6] send-email: fix " Markus Heidelberg
2009-06-08  6:43   ` [PATCH v2 " Markus Heidelberg
2009-06-07 21:40 ` [PATCH 6/6] doc/send-email: clarify the behavior of --in-reply-to with --no-thread Markus Heidelberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd49f8b1f.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=markus.heidelberg@web.de \
    --cc=mfwitten@gmail.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).