git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org, szeder@ira.uka.de,
	Bert Wesarg <bert.wesarg@googlemail.com>
Subject: Re: [PATCH 1/3] for-each-ref: utilize core.warnambiguousrefs for strict refname:short format
Date: Fri, 17 Oct 2008 16:58:56 -0700	[thread overview]
Message-ID: <7vod1ieptr.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1222074591-26548-1-git-send-email-bert.wesarg@googlemail.com

Shawn, was there any issue with this one?  The patch changes the function
signature for no good reason (at least, it does not have anything to do
with the stated purpose of the change), but other than that, I think what
it attempts to do makes sense.

  parent reply	other threads:[~2008-10-18  0:00 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-22  9:09 [PATCH 1/3] for-each-ref: utilize core.warnambiguousrefs for strict refname:short format Bert Wesarg
2008-09-22  9:09 ` [PATCH 2/3] for-each-ref: factor out get_short_ref() into refs.c:abbreviate_refname() Bert Wesarg
2008-09-22  9:09   ` [PATCH 3/3] git abbref-ref: new porcelain for abbreviate_ref() Bert Wesarg
2008-09-22 15:32     ` Shawn O. Pearce
2008-09-22 15:55       ` Junio C Hamano
2008-09-22 16:45         ` Bert Wesarg
2008-09-22 16:43       ` Bert Wesarg
2008-09-22 16:27 ` [PATCH 1/3] for-each-ref: utilize core.warnambiguousrefs for strict refname:short format Junio C Hamano
2008-09-22 18:00   ` Bert Wesarg
2008-10-17 23:58 ` Junio C Hamano [this message]
2008-10-18  1:50   ` Shawn O. Pearce
2008-10-18  6:55     ` Bert Wesarg
  -- strict thread matches above, loose matches on Subject: below --
2009-04-07  7:02 [RFC/PATCH 0/5] making upstream branch information accessible Jeff King
2009-04-07  7:05 ` [PATCH 1/5] for-each-ref: refactor get_short_ref function Jeff King
2009-04-07  7:06 ` [PATCH 2/5] for-each-ref: refactor refname handling Jeff King
2009-04-08  6:22   ` Junio C Hamano
2009-04-08  6:27     ` Jeff King
2009-04-07  7:09 ` [PATCH 3/5] for-each-ref: add "upstream" format field Jeff King
2009-04-07  7:14 ` [PATCH 4/5] make get_short_ref a public function Jeff King
2009-04-07  7:39   ` Bert Wesarg
2009-04-09  8:18     ` Jeff King
2009-04-09  9:05       ` Bert Wesarg
2009-04-11 17:14         ` [PATCH&RFC] get_short_ref(): add strict mode Bert Wesarg
2009-04-11 19:23           ` Junio C Hamano
2009-04-11 19:50             ` Bert Wesarg
2009-04-11 20:35               ` [PATCH] for-each-ref: refname:short utilize core.warnAmbiguousRefs Bert Wesarg
2009-04-13  8:15         ` [PATCH 4/5] make get_short_ref a public function Jeff King
2009-04-07  7:57   ` Michael J Gruber
2009-04-07  7:16 ` [PATCH 5/5] branch: show upstream branch when double verbose Jeff King
2009-04-07  8:02   ` Michael J Gruber
2009-04-09  8:23     ` Jeff King
2009-04-09 10:15       ` Santi Béjar
2009-04-13  8:34         ` Jeff King
2009-04-13 17:04           ` Wincent Colaiuta
2009-04-07  8:12   ` Paolo Ciarrocchi
2009-04-07  7:33 ` [PATCH] for-each-ref: remove multiple xstrdup() in get_short_ref() Bert Wesarg
2009-04-07  7:44   ` Jeff King
2009-04-07  7:54     ` Bert Wesarg
2009-04-07 21:41     ` Jeff King
2009-04-07  7:44   ` Bert Wesarg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vod1ieptr.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=bert.wesarg@googlemail.com \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).