From: Junio C Hamano <gitster@pobox.com>
To: David Michael <fedora.dm0@gmail.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [BUG/PATCH] setup: Copy an environment variable to avoid overwrites
Date: Fri, 04 Jan 2013 20:32:10 -0800 [thread overview]
Message-ID: <7vobh4qmgl.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vsj6gqvhc.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Fri, 04 Jan 2013 17:17:19 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> ... So even if the standard allowed the
> returned value to be volatile across calls to getenv(3),...
> ...
> In fact,
>
> http://pubs.opengroup.org/onlinepubs/9699919799/functions/getenv.html
>
> says that only ...
Apparently I wasn't even reading what I was quoting carefully
enough. The above does include getenv() as one of the functions
that are allowed to invalidate earlier return values.
Sorry about that. I'll go back to bed (I am a bit under the weather
and OOO today). The conclusion in my original message is still
valid.
> Having said that, we do have codepaths to update a handful of
> environment variables ourselves (GIT_DIR is among them), so I think
> your patch is a good safety measure in general.
next prev parent reply other threads:[~2013-01-05 4:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-05 0:35 [BUG/PATCH] setup: Copy an environment variable to avoid overwrites David Michael
2013-01-05 1:17 ` Junio C Hamano
2013-01-05 2:15 ` David Michael
2013-01-05 4:32 ` Junio C Hamano [this message]
2013-01-05 2:45 ` Duy Nguyen
2013-01-05 4:38 ` Junio C Hamano
2013-01-05 6:24 ` Duy Nguyen
2013-01-05 6:47 ` Junio C Hamano
2013-01-05 8:55 ` [PATCH] Add getenv.so for catching invalid getenv() use via LD_PRELOAD Nguyễn Thái Ngọc Duy
2013-01-05 10:39 ` Matt Kraai
2013-01-05 11:37 ` Duy Nguyen
2013-01-05 22:53 ` Jonathan Nieder
2013-01-07 15:45 ` David Michael
2013-01-07 15:28 ` [BUG/PATCH] setup: Copy an environment variable to avoid overwrites Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vobh4qmgl.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=fedora.dm0@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).