From: Matt Kraai <kraai@ftbfs.org>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
David Michael <fedora.dm0@gmail.com>
Subject: Re: [PATCH] Add getenv.so for catching invalid getenv() use via LD_PRELOAD
Date: Sat, 5 Jan 2013 02:39:00 -0800 [thread overview]
Message-ID: <20130105103900.GA4200@ftbfs.org> (raw)
In-Reply-To: <1357376146-7155-1-git-send-email-pclouds@gmail.com>
On Sat, Jan 05, 2013 at 03:55:46PM +0700, Nguyễn Thái Ngọc Duy wrote:
> Perhaps this will help the getenv bug hunting (I assume we do the
> hunting on Linux platform only). So far it catches this and is stuck
> at getenv in git_pager().
It seems like a static analysis tool might be able to detect these
problems. Is there a way to do so using sparse?
> + n = backtrace(buffer, 100);
> + symbols = backtrace_symbols(buffer, n);
> + if (symbols) {
> + for (i = 0;i < n; i++)
s/;i/; i/
--
Matt Kraai
https://ftbfs.org/kraai
next prev parent reply other threads:[~2013-01-05 10:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-05 0:35 [BUG/PATCH] setup: Copy an environment variable to avoid overwrites David Michael
2013-01-05 1:17 ` Junio C Hamano
2013-01-05 2:15 ` David Michael
2013-01-05 4:32 ` Junio C Hamano
2013-01-05 2:45 ` Duy Nguyen
2013-01-05 4:38 ` Junio C Hamano
2013-01-05 6:24 ` Duy Nguyen
2013-01-05 6:47 ` Junio C Hamano
2013-01-05 8:55 ` [PATCH] Add getenv.so for catching invalid getenv() use via LD_PRELOAD Nguyễn Thái Ngọc Duy
2013-01-05 10:39 ` Matt Kraai [this message]
2013-01-05 11:37 ` Duy Nguyen
2013-01-05 22:53 ` Jonathan Nieder
2013-01-07 15:45 ` David Michael
2013-01-07 15:28 ` [BUG/PATCH] setup: Copy an environment variable to avoid overwrites Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130105103900.GA4200@ftbfs.org \
--to=kraai@ftbfs.org \
--cc=fedora.dm0@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).