From: Junio C Hamano <gitster@pobox.com>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] help: correct behavior for is_executable on Windows
Date: Mon, 13 Aug 2012 10:48:14 -0700 [thread overview]
Message-ID: <7vmx1yel9d.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120813170221.GB6418@book.hvoigt.net> (Heiko Voigt's message of "Mon, 13 Aug 2012 19:02:23 +0200")
Heiko Voigt <hvoigt@hvoigt.net> writes:
> Since the code for cygwin and windows in general is almost the same I would
> extract one function for them where I leave in one ifdef for cygwin.
>
> E.g. like this:
>
>
> static int is_executable(const char *name)
> {
> struct stat st;
>
> if (stat(name, &st) || /* stat, not lstat */
> !S_ISREG(st.st_mode))
> return 0;
>
> fill_platform_stat(name, &st);
>
> return st.st_mode & S_IXUSR;
> }
>
> which I could then define to a no op on posix. That way we avoid code
> duplication in the platform specific functions.
>
> What do you think?
Does having the "stat()" help on Windows in any way? Does it ever
return an executable bit by itself?
If not, Windows compat/ implementation may want to skip issuing a
useless stat() and write it as
if (has_extension(".exe"))
return 1;
if (contents_begins_with("MZ") || contents_begins_with("#!"))
return 1;
return 0;
without ever talking about stat() which is POSIXism compat/
implementation for Windows does not have to worry about.
And that was the reason I suggested making the whole implementation
of path_is_executable() overridable by compat/ layer.
But if having "stat()" helps on Windows, then your counterproposal
is good enough for me.
Thanks.
next prev parent reply other threads:[~2012-08-13 17:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-11 7:00 [PATCH] help: correct behavior for is_executable on Windows Heiko Voigt
2012-08-12 4:30 ` Junio C Hamano
2012-08-13 17:02 ` Heiko Voigt
2012-08-13 17:48 ` Junio C Hamano [this message]
2012-08-15 16:50 ` Heiko Voigt
2012-08-15 17:53 ` Junio C Hamano
2012-08-15 19:39 ` Junio C Hamano
2012-08-15 22:29 ` Heiko Voigt
2012-08-15 23:15 ` Junio C Hamano
2012-08-16 2:02 ` Junio C Hamano
2012-08-16 16:35 ` Heiko Voigt
-- strict thread matches above, loose matches on Subject: below --
2017-01-27 13:50 Johannes Schindelin
2017-01-27 18:43 ` Junio C Hamano
2017-01-30 12:44 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmx1yel9d.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).