From: Heiko Voigt <hvoigt@hvoigt.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] help: correct behavior for is_executable on Windows
Date: Thu, 16 Aug 2012 18:35:43 +0200 [thread overview]
Message-ID: <20120816163543.GA45275@book.hvoigt.net> (raw)
In-Reply-To: <7vwr0z387c.fsf@alter.siamese.dyndns.org>
Hi Junio,
On Wed, Aug 15, 2012 at 07:02:31PM -0700, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> > My preference is to remove "static int is_executable()" function
> > from help.c, have an...
> > ... I wouldn't mind seeing the implementation of posix_is_executable()
> > in help.c, which will be dead-code on Windows and Cygwin, if that
> > makes linking and Makefile easier.
>
> An outline of such a change might look like this.
Thanks for the outline and the clarification, I will use it to cook up
something.
Cheers Heiko
next prev parent reply other threads:[~2012-08-16 16:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-11 7:00 [PATCH] help: correct behavior for is_executable on Windows Heiko Voigt
2012-08-12 4:30 ` Junio C Hamano
2012-08-13 17:02 ` Heiko Voigt
2012-08-13 17:48 ` Junio C Hamano
2012-08-15 16:50 ` Heiko Voigt
2012-08-15 17:53 ` Junio C Hamano
2012-08-15 19:39 ` Junio C Hamano
2012-08-15 22:29 ` Heiko Voigt
2012-08-15 23:15 ` Junio C Hamano
2012-08-16 2:02 ` Junio C Hamano
2012-08-16 16:35 ` Heiko Voigt [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-27 13:50 Johannes Schindelin
2017-01-27 18:43 ` Junio C Hamano
2017-01-30 12:44 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816163543.GA45275@book.hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).