From: Junio C Hamano <gitster@pobox.com>
To: Petr Baudis <pasky@suse.cz>
Cc: Lea Wiemann <lewiemann@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] perl/Git.pm: add parse_rev method
Date: Fri, 30 May 2008 14:25:58 -0700 [thread overview]
Message-ID: <7vd4n3iivt.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080530210531.GH18781@machine.or.cz> (Petr Baudis's message of "Fri, 30 May 2008 23:05:31 +0200")
Petr Baudis <pasky@suse.cz> writes:
> On Fri, May 30, 2008 at 10:27:50PM +0200, Lea Wiemann wrote:
>> The parse_rev method takes a revision name and returns a SHA1 hash,
>> like the git-rev-parse command.
>>
>> Signed-off-by: Lea Wiemann <LeWiemann@gmail.com>
>
> Nice, this looks quite sane!
Perhaps, but except for the use of nonstandard try...catch. I have been
wondering if we can move away from it, with the goal of eventually getting
rid of the construct altogether.
Didn't we hear from Randal that the construct is known to be leaky?
next prev parent reply other threads:[~2008-05-30 21:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 4:43 [PATCH] perl/Git.pm: add rev_parse method Lea Wiemann
2008-05-30 7:03 ` Lea Wiemann
2008-05-30 9:59 ` Petr Baudis
2008-05-30 15:15 ` Merging strategy for extending Git.pm (was: [PATCH] perl/Git.pm: add rev_parse method) Lea Wiemann
2008-05-30 23:20 ` Merging strategy for extending Git.pm Junio C Hamano
2008-05-31 11:38 ` Merging strategy for extending Git.pm (was: [PATCH] perl/Git.pm: add rev_parse method) Johannes Schindelin
2008-05-31 12:42 ` Merging strategy for extending Git.pm Lea Wiemann
2008-05-31 12:52 ` Johannes Schindelin
2008-05-30 20:28 ` [PATCH] perl/Git.pm: add rev_parse method Junio C Hamano
2008-05-30 9:50 ` Petr Baudis
2008-05-30 20:27 ` [PATCH] perl/Git.pm: add parse_rev method Lea Wiemann
2008-05-30 21:05 ` Petr Baudis
2008-05-30 21:25 ` Junio C Hamano [this message]
2008-05-30 21:44 ` Randal L. Schwartz
2008-05-30 21:59 ` Lea Wiemann
2008-05-30 22:03 ` Randal L. Schwartz
2008-05-30 22:05 ` Lea Wiemann
2008-05-30 22:19 ` Junio C Hamano
2008-05-31 11:50 ` Johannes Schindelin
2008-05-31 12:17 ` Support for old Perl versions Petr Baudis
2008-05-31 12:32 ` Johannes Schindelin
2008-05-30 21:49 ` [PATCH] perl/Git.pm: add parse_rev method Petr Baudis
2008-05-31 13:52 ` [PATCH v2] " Lea Wiemann
2008-06-01 3:17 ` [PATCH v3] " Lea Wiemann
2008-06-01 3:17 ` Lea Wiemann
2008-06-01 17:38 ` Lea Wiemann
2008-06-01 21:54 ` Miklos Vajna
2008-06-01 22:51 ` Lea Wiemann
2008-06-02 4:59 ` Junio C Hamano
2008-06-02 13:51 ` Lea Wiemann
2008-06-01 23:09 ` [PATCH v4] perl/Git.pm: add get_hash method Lea Wiemann
2008-06-01 23:24 ` Lea Wiemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4n3iivt.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lewiemann@gmail.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).