git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Lea Wiemann <lewiemann@gmail.com>
To: "Randal L. Schwartz" <merlyn@stonehenge.com>
Cc: Junio C Hamano <gitster@pobox.com>, Petr Baudis <pasky@suse.cz>,
	git@vger.kernel.org
Subject: Re: [PATCH] perl/Git.pm: add parse_rev method
Date: Fri, 30 May 2008 23:59:35 +0200	[thread overview]
Message-ID: <484078C7.7020008@gmail.com> (raw)
In-Reply-To: <86r6bjmpqc.fsf@blue.stonehenge.com>

Randal L. Schwartz wrote:
> [Move to eval/die.]  No leak there.

I'm not an experienced Perl hacker, but I intuitively liked the 
throw/catch method better than the eval/die method.

If I read 
http://www.nntp.perl.org/group/perl.perl5.porters/2006/03/msg110331.html 
correctly, this has been fixed in recent 5.8 versions, so it would 
really only affect 5.6.  But perhaps we don't care about 5.6. ;-) 
People who run into serious memory issues with 5.6 will have to upgrade, 
and the existing functionality that programs like git-send-email or 
git-svn rely on seems to work fine with the memory leaks, so using 
throw/catch further probably won't cause any regressions for them.

I'm honestly not too keen on sacrificing time (or code prettiness) on 
5.6 compatibility, so if there are no reasons besides the memory leak to 
move away from throw/catch, perhaps we can just keep using it?

-- Lea

  reply	other threads:[~2008-05-30 22:00 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-30  4:43 [PATCH] perl/Git.pm: add rev_parse method Lea Wiemann
2008-05-30  7:03 ` Lea Wiemann
2008-05-30  9:59   ` Petr Baudis
2008-05-30 15:15     ` Merging strategy for extending Git.pm (was: [PATCH] perl/Git.pm: add rev_parse method) Lea Wiemann
2008-05-30 23:20       ` Merging strategy for extending Git.pm Junio C Hamano
2008-05-31 11:38       ` Merging strategy for extending Git.pm (was: [PATCH] perl/Git.pm: add rev_parse method) Johannes Schindelin
2008-05-31 12:42         ` Merging strategy for extending Git.pm Lea Wiemann
2008-05-31 12:52           ` Johannes Schindelin
2008-05-30 20:28   ` [PATCH] perl/Git.pm: add rev_parse method Junio C Hamano
2008-05-30  9:50 ` Petr Baudis
2008-05-30 20:27   ` [PATCH] perl/Git.pm: add parse_rev method Lea Wiemann
2008-05-30 21:05     ` Petr Baudis
2008-05-30 21:25       ` Junio C Hamano
2008-05-30 21:44         ` Randal L. Schwartz
2008-05-30 21:59           ` Lea Wiemann [this message]
2008-05-30 22:03             ` Randal L. Schwartz
2008-05-30 22:05               ` Lea Wiemann
2008-05-30 22:19             ` Junio C Hamano
2008-05-31 11:50             ` Johannes Schindelin
2008-05-31 12:17               ` Support for old Perl versions Petr Baudis
2008-05-31 12:32                 ` Johannes Schindelin
2008-05-30 21:49         ` [PATCH] perl/Git.pm: add parse_rev method Petr Baudis
2008-05-31 13:52 ` [PATCH v2] " Lea Wiemann
2008-06-01  3:17   ` [PATCH v3] " Lea Wiemann
2008-06-01  3:17     ` Lea Wiemann
2008-06-01 17:38       ` Lea Wiemann
2008-06-01 21:54         ` Miklos Vajna
2008-06-01 22:51           ` Lea Wiemann
2008-06-02  4:59             ` Junio C Hamano
2008-06-02 13:51               ` Lea Wiemann
2008-06-01 23:09       ` [PATCH v4] perl/Git.pm: add get_hash method Lea Wiemann
2008-06-01 23:24         ` Lea Wiemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484078C7.7020008@gmail.com \
    --to=lewiemann@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=merlyn@stonehenge.com \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).