git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Philippe Bruhat (BooK)" <book@cpan.org>
Cc: git@vger.kernel.org
Subject: Re: Multiple -M options for git-cvsimport
Date: Sat, 01 Mar 2008 12:24:39 -0800	[thread overview]
Message-ID: <7vbq5yyyyg.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 7vejav7zns.fsf@gitster.siamese.dyndns.org

Junio C Hamano <gitster@pobox.com> writes:

> "Philippe Bruhat (BooK)" <book@cpan.org> writes:
>
>> On Thu, Feb 28, 2008 at 12:07:46PM -0800, Junio C Hamano wrote:
>>
>>> I'll take a look at them later, when I have enough time to fish
>>> for messages and discussions from earlier round in the list
>>> archive in order to process this.
>>
>> You can ignore my previous messages, then. These four patches were
>> rebased on the top of master, and correct the problems that were
>> previously pointed to me.
>
> I do not work that way.  I am a trust-but-verify kind of person.
>
> So I dug up the old ones and the discussion.  The series looks
> fine.
> ...
> cvsimport: have default merge regex allow for dashes in the branch name
> ...
> cvsimport: allow for multiple -M options
>
>   Ok.
> ...
> cvsimport: document that -M can be used multiple times
> cvsimport: configure Getopt::Long to bundle options
>
>   Ok.  Why isn't bundling the default, I have to wonder...

I take these back.  

The last one is an "Oops, the second one was an utter crap, it does not
even pass the testsuite, well let's patch it up with an extra commit at
the end."

Please don't do this.  We do not have to record earlier mistakes in the
public history.

I've squashed 4/4 into 2/4 and made it a 3-patch series.

      reply	other threads:[~2008-03-01 20:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28 10:18 Multiple -M options for git-cvsimport Philippe Bruhat (BooK)
2008-02-28 10:18 ` [PATCH] cvsimport: have default merge regex allow for dashes in the branch name Philippe Bruhat (BooK)
2008-02-28 10:18   ` [PATCH] cvsimport: allow for multiple -M options Philippe Bruhat (BooK)
2008-02-28 10:18     ` [PATCH] cvsimport: document that -M can be used multiple times Philippe Bruhat (BooK)
2008-02-28 10:18       ` [PATCH] cvsimport: configure Getopt::Long to bundle options Philippe Bruhat (BooK)
2008-02-28 20:07 ` Multiple -M options for git-cvsimport Junio C Hamano
2008-02-29 10:02   ` Philippe Bruhat (BooK)
2008-03-01  5:59     ` Junio C Hamano
2008-03-01 20:24       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbq5yyyyg.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=book@cpan.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).