From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: Multiple -M options for git-cvsimport Date: Sat, 01 Mar 2008 12:24:39 -0800 Message-ID: <7vbq5yyyyg.fsf@gitster.siamese.dyndns.org> References: <1204193904-3652-1-git-send-email-book@cpan.org> <7vzltkj14d.fsf@gitster.siamese.dyndns.org> <20080229100241.GA6777@plop.home.bruhat.net> <7vejav7zns.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org To: "Philippe Bruhat (BooK)" X-From: git-owner@vger.kernel.org Sat Mar 01 21:26:01 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JVYHM-0002Nm-Ma for gcvg-git-2@gmane.org; Sat, 01 Mar 2008 21:25:57 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757964AbYCAUYv (ORCPT ); Sat, 1 Mar 2008 15:24:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757816AbYCAUYv (ORCPT ); Sat, 1 Mar 2008 15:24:51 -0500 Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:64922 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757220AbYCAUYu (ORCPT ); Sat, 1 Mar 2008 15:24:50 -0500 Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 9EE0E1610; Sat, 1 Mar 2008 15:24:45 -0500 (EST) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id F3B99160C; Sat, 1 Mar 2008 15:24:42 -0500 (EST) User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Junio C Hamano writes: > "Philippe Bruhat (BooK)" writes: > >> On Thu, Feb 28, 2008 at 12:07:46PM -0800, Junio C Hamano wrote: >> >>> I'll take a look at them later, when I have enough time to fish >>> for messages and discussions from earlier round in the list >>> archive in order to process this. >> >> You can ignore my previous messages, then. These four patches were >> rebased on the top of master, and correct the problems that were >> previously pointed to me. > > I do not work that way. I am a trust-but-verify kind of person. > > So I dug up the old ones and the discussion. The series looks > fine. > ... > cvsimport: have default merge regex allow for dashes in the branch name > ... > cvsimport: allow for multiple -M options > > Ok. > ... > cvsimport: document that -M can be used multiple times > cvsimport: configure Getopt::Long to bundle options > > Ok. Why isn't bundling the default, I have to wonder... I take these back. The last one is an "Oops, the second one was an utter crap, it does not even pass the testsuite, well let's patch it up with an extra commit at the end." Please don't do this. We do not have to record earlier mistakes in the public history. I've squashed 4/4 into 2/4 and made it a 3-patch series.