* [PATCH] web--browse: support /usr/bin/cygstart on Cygwin
@ 2013-06-21 7:24 Yaakov (Cygwin/X)
2013-06-21 16:06 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Yaakov (Cygwin/X) @ 2013-06-21 7:24 UTC (permalink / raw)
To: git
From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
While both GUI and console Cygwin browsers do exist, anecdotal evidence
suggests most users rely on their native Windows browser. cygstart,
which is a long-standing part of the base Cygwin installation, will
cause the page to be opened in the default Windows browser (the one
registered to open .html files).
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
---
Documentation/git-web--browse.txt | 1 +
git-web--browse.sh | 9 +++++++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-web--browse.txt b/Documentation/git-web--browse.txt
index ba79cb4..5aec4ec 100644
--- a/Documentation/git-web--browse.txt
+++ b/Documentation/git-web--browse.txt
@@ -34,6 +34,7 @@ The following browsers (or commands) are currently supported:
* dillo
* open (this is the default under Mac OS X GUI)
* start (this is the default under MinGW)
+* cygstart (this is the default under Cygwin)
Custom commands may also be specified.
diff --git a/git-web--browse.sh b/git-web--browse.sh
index 9f44679..9fc1dba 100755
--- a/git-web--browse.sh
+++ b/git-web--browse.sh
@@ -33,7 +33,8 @@ valid_tool() {
case "$1" in
firefox | iceweasel | seamonkey | iceape | \
chrome | google-chrome | chromium | chromium-browser |\
- konqueror | opera | w3m | elinks | links | lynx | dillo | open | start)
+ konqueror | opera | w3m | elinks | links | lynx | dillo | open |\
+ start | cygstart)
;; # happy
*)
valid_custom_tool "$1" || return 1
@@ -127,6 +128,10 @@ if test -z "$browser" ; then
if test -x /bin/start; then
browser_candidates="start $browser_candidates"
fi
+ # /usr/bin/cygstart indicates Cygwin
+ if test -x /usr/bin/cygstart; then
+ browser_candidates="cygstart $browser_candidates"
+ fi
for i in $browser_candidates; do
init_browser_path $i
@@ -174,7 +179,7 @@ konqueror)
;;
esac
;;
-w3m|elinks|links|lynx|open)
+w3m|elinks|links|lynx|open|cygstart)
"$browser_path" "$@"
;;
start)
--
1.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] web--browse: support /usr/bin/cygstart on Cygwin
2013-06-21 7:24 [PATCH] web--browse: support /usr/bin/cygstart on Cygwin Yaakov (Cygwin/X)
@ 2013-06-21 16:06 ` Junio C Hamano
2013-07-23 22:28 ` Yaakov (Cygwin/X)
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2013-06-21 16:06 UTC (permalink / raw)
To: Yaakov (Cygwin/X); +Cc: git
"Yaakov (Cygwin/X)" <yselkowitz@users.sourceforge.net> writes:
> From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
>
> While both GUI and console Cygwin browsers do exist, anecdotal evidence
> suggests most users rely on their native Windows browser. cygstart,
> which is a long-standing part of the base Cygwin installation, will
> cause the page to be opened in the default Windows browser (the one
> registered to open .html files).
>
> Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Will queue and wait for somebody from Cygwin land to comment.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] web--browse: support /usr/bin/cygstart on Cygwin
2013-06-21 16:06 ` Junio C Hamano
@ 2013-07-23 22:28 ` Yaakov (Cygwin/X)
2013-07-25 15:59 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Yaakov (Cygwin/X) @ 2013-07-23 22:28 UTC (permalink / raw)
To: git
On 2013-06-21 11:06, Junio C Hamano wrote:
>> From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
>>
>> While both GUI and console Cygwin browsers do exist, anecdotal evidence
>> suggests most users rely on their native Windows browser. cygstart,
>> which is a long-standing part of the base Cygwin installation, will
>> cause the page to be opened in the default Windows browser (the one
>> registered to open .html files).
>>
>> Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
>
> Will queue and wait for somebody from Cygwin land to comment.
Ping? Is there someone in particular whose input you are looking for?
Yaakov
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] web--browse: support /usr/bin/cygstart on Cygwin
2013-07-23 22:28 ` Yaakov (Cygwin/X)
@ 2013-07-25 15:59 ` Junio C Hamano
0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2013-07-25 15:59 UTC (permalink / raw)
To: Yaakov (Cygwin/X); +Cc: git
"Yaakov (Cygwin/X)" <yselkowitz@users.sourceforge.net> writes:
>>> Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
>>
>> Will queue and wait for somebody from Cygwin land to comment.
>
> Ping? Is there someone in particular whose input you are looking for?
Nobody in particular. Nobody complained nor reported breakages, so
we are good to go ;-)
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-25 15:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-21 7:24 [PATCH] web--browse: support /usr/bin/cygstart on Cygwin Yaakov (Cygwin/X)
2013-06-21 16:06 ` Junio C Hamano
2013-07-23 22:28 ` Yaakov (Cygwin/X)
2013-07-25 15:59 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).