From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Arnout Engelen <arnouten@bzzt.net>, git@vger.kernel.org
Subject: Re: [PATCH] log which temporary file could not be created
Date: Mon, 11 Oct 2010 20:56:59 -0700 [thread overview]
Message-ID: <7v8w24oygk.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 20101010180909.GA12320@burratino
Jonathan Nieder <jrnieder@gmail.com> writes:
> Arnout Engelen wrote:
>> On Sat, Oct 09, 2010 at 09:41:24PM -0500, Jonathan Nieder wrote:
>
>>> fatal: Unable to create temporary file '.merge_file_Sc7R5c': File exists
>>> fatal: Unable to create temporary file 'newrepo/.git/tOWHcxk': No space left on device
>>
>> Perhaps we should also log the current working directory when the temporary
>> filename is relative?
>
> Let's step back for a moment. Was there an example that prompted
> this patch? Were you aware of where git would be trying to create
> files in that example? (I'm genuinely curious.)
>
> Converting the filename to an absolute path with make_absolute_path
> might be useful, but I am not entirely sure it is worth the
> complication.
For that matter, I am not sure if it is worth the strdup "just in case it
fails" either.
next prev parent reply other threads:[~2010-10-12 3:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-09 20:17 [PATCH] log which temporary file could not be created Arnout Engelen
2010-10-10 2:41 ` Jonathan Nieder
2010-10-10 10:33 ` Arnout Engelen
2010-10-10 18:09 ` Jonathan Nieder
2010-10-10 18:56 ` Arnout Engelen
2010-10-12 20:19 ` [PATCH] send-pack: avoid redundant "pack-objects died with strange error" Jonathan Nieder
2010-10-16 6:04 ` [PATCH v2] " Jonathan Nieder
2010-10-16 9:25 ` Johannes Sixt
2010-10-16 17:09 ` [PATCH v3] " Jonathan Nieder
2010-10-12 3:56 ` Junio C Hamano [this message]
2010-10-18 9:20 ` [PATCH] log which temporary file could not be created Arnout Engelen
[not found] ` <20101021205800.GC12685@burratino>
2010-11-04 0:24 ` Arnout Engelen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8w24oygk.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=arnouten@bzzt.net \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).