From: Jonathan Nieder <jrnieder@gmail.com>
To: Arnout Engelen <arnouten@bzzt.net>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] log which temporary file could not be created
Date: Sat, 9 Oct 2010 21:41:24 -0500 [thread overview]
Message-ID: <20101010024124.GA20305@burratino> (raw)
In-Reply-To: <20101009201751.GK9348@bzzt.net>
Hi,
Arnout Engelen wrote:
> When creating a temporary file, log the template.
Since mkstemp modifies its template, these hopefully would print the
actual filename on errors. Examples:
fatal: Unable to create temporary file '.merge_file_Sc7R5c': File exists
fatal: Unable to create temporary file 'newrepo/.git/tOWHcxk': No space left on device
Unfortunately some mkstemp()s (such as that used to implement
git_mkstemp_mode()) clear the template on error, which would result in
fatal: Unable to create temporary file '': Permission denied
What should git do in this situation?
> Useful for making debugging
> problems like file permission mistakes easier.
Agreed. Thanks.
next prev parent reply other threads:[~2010-10-10 2:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-09 20:17 [PATCH] log which temporary file could not be created Arnout Engelen
2010-10-10 2:41 ` Jonathan Nieder [this message]
2010-10-10 10:33 ` Arnout Engelen
2010-10-10 18:09 ` Jonathan Nieder
2010-10-10 18:56 ` Arnout Engelen
2010-10-12 20:19 ` [PATCH] send-pack: avoid redundant "pack-objects died with strange error" Jonathan Nieder
2010-10-16 6:04 ` [PATCH v2] " Jonathan Nieder
2010-10-16 9:25 ` Johannes Sixt
2010-10-16 17:09 ` [PATCH v3] " Jonathan Nieder
2010-10-12 3:56 ` [PATCH] log which temporary file could not be created Junio C Hamano
2010-10-18 9:20 ` Arnout Engelen
[not found] ` <20101021205800.GC12685@burratino>
2010-11-04 0:24 ` Arnout Engelen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101010024124.GA20305@burratino \
--to=jrnieder@gmail.com \
--cc=arnouten@bzzt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).