From: Junio C Hamano <gitster@pobox.com>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: "Santi Béjar" <santi@agolina.net>, git@vger.kernel.org
Subject: Re: [PATCH] rebase -i: use 'read -r' to avoid backslash acting as an escape character
Date: Wed, 07 Jul 2010 17:29:29 -0700 [thread overview]
Message-ID: <7v7hl6stna.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20100707094620.GC31048@genesis.frugalware.org> (Miklos Vajna's message of "Wed\, 7 Jul 2010 11\:46\:20 +0200")
Miklos Vajna <vmiklos@frugalware.org> writes:
> On Wed, Jul 07, 2010 at 11:22:29AM +0200, Santi Béjar <santi@agolina.net> wrote:
>> No. This one:
>>
>> http://article.gmane.org/gmane.comp.version-control.git/150328
>>
>> :-)
>
> Heh, then sorry for the noise. I noticed the problem on 2th, added the
> "I should fix this" to my TODO, then made the patch yesterday. I forgot
> to check the list archive again before sending the patch. ;-)
Thanks anyway. It may have been a bit of duplicated effort, but served as
a sanity check as well.
Our patches do seem to fix the reading side of the issue, but I am not
sure if the writing side needs further fix. If I recall, the script had
liberal use of "echo $var"; some implementations of echo interprets
backslash sequence without being asked with an explicit "-e".
next prev parent reply other threads:[~2010-07-08 0:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 22:55 [PATCH] rebase -i: use 'read -r' to avoid backslash acting as an escape character Miklos Vajna
2010-07-07 5:25 ` Junio C Hamano
2010-07-07 9:16 ` Miklos Vajna
2010-07-07 9:22 ` Santi Béjar
2010-07-07 9:46 ` Miklos Vajna
2010-07-08 0:29 ` Junio C Hamano [this message]
2010-07-08 10:35 ` Miklos Vajna
2010-07-08 17:14 ` [RFC] war on echo in scripts Jonathan Nieder
2010-07-08 22:57 ` Andreas Schwab
2010-07-09 2:46 ` Jonathan Nieder
2010-07-09 3:47 ` Sverre Rabbelier
2010-07-09 4:46 ` Junio C Hamano
2010-07-09 14:30 ` Jonathan Nieder
2010-07-09 16:30 ` Junio C Hamano
2010-07-09 11:52 ` Ævar Arnfjörð Bjarmason
2010-07-09 14:10 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7hl6stna.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=santi@agolina.net \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).