From: Jonathan Nieder <jrnieder@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "Miklos Vajna" <vmiklos@frugalware.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Santi Béjar" <santi@agolina.net>,
git@vger.kernel.org
Subject: Re: [RFC] war on echo in scripts
Date: Thu, 8 Jul 2010 21:46:33 -0500 [thread overview]
Message-ID: <20100709024633.GA13739@dert.cs.uchicago.edu> (raw)
In-Reply-To: <m2k4p58tum.fsf@igel.home>
Andreas Schwab wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>> die() {
>> - echo >&2 "$@"
>> + printf >&2 '%s\n' "$@"
>
> You probably want to use "$*" here, though it wouldn't matter for the
> uses of die in this file.
Hmm, maybe something like this would be easier.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
diff --git a/git-sh-setup.sh b/git-sh-setup.sh
index 6131670..b38b40b 100644
--- a/git-sh-setup.sh
+++ b/git-sh-setup.sh
@@ -39,6 +39,10 @@ git_broken_path_fix () {
# @@BROKEN_PATH_FIX@@
+echo() {
+ printf '%s\n' "$*"
+}
+
die() {
echo >&2 "$@"
exit 1
--
next prev parent reply other threads:[~2010-07-09 3:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 22:55 [PATCH] rebase -i: use 'read -r' to avoid backslash acting as an escape character Miklos Vajna
2010-07-07 5:25 ` Junio C Hamano
2010-07-07 9:16 ` Miklos Vajna
2010-07-07 9:22 ` Santi Béjar
2010-07-07 9:46 ` Miklos Vajna
2010-07-08 0:29 ` Junio C Hamano
2010-07-08 10:35 ` Miklos Vajna
2010-07-08 17:14 ` [RFC] war on echo in scripts Jonathan Nieder
2010-07-08 22:57 ` Andreas Schwab
2010-07-09 2:46 ` Jonathan Nieder [this message]
2010-07-09 3:47 ` Sverre Rabbelier
2010-07-09 4:46 ` Junio C Hamano
2010-07-09 14:30 ` Jonathan Nieder
2010-07-09 16:30 ` Junio C Hamano
2010-07-09 11:52 ` Ævar Arnfjörð Bjarmason
2010-07-09 14:10 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100709024633.GA13739@dert.cs.uchicago.edu \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=santi@agolina.net \
--cc=schwab@linux-m68k.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).