From: Junio C Hamano <gitster@pobox.com>
To: "Spencer E. Olson" <olsonse@umich.edu>
Cc: git@vger.kernel.org, Tay Ray Chuan <rctay89@gmail.com>,
Nick Hengeveld <nickh@reactrix.com>,
Mark Lodato <lodatom@gmail.com>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH v3] Allow HTTP user agent string to be modified.
Date: Wed, 11 Aug 2010 13:08:41 -0700 [thread overview]
Message-ID: <7v62zgyks6.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1281504288-31836-1-git-send-email-olsonse@umich.edu> (Spencer E. Olson's message of "Tue\, 10 Aug 2010 23\:24\:48 -0600")
"Spencer E. Olson" <olsonse@umich.edu> writes:
> diff --git a/http.c b/http.c
> index 1320c50..b0b6925 100644
> --- a/http.c
> +++ b/http.c
> @@ -41,6 +41,7 @@ static long curl_low_speed_time = -1;
> static int curl_ftp_no_epsv;
> static const char *curl_http_proxy;
> static char *user_name, *user_pass;
> +static const char *user_agent;
>
> #if LIBCURL_VERSION_NUM >= 0x071700
> /* Use CURLOPT_KEYPASSWD as is */
> @@ -196,6 +197,9 @@ static int http_options(const char *var, const char *value, void *cb)
> return 0;
> }
>
> + if (!strcmp("http.useragent", var))
> + return git_config_string(&user_agent, var, value);
> +
> /* Fall back on the default ones */
> return git_default_config(var, value, cb);
> }
> @@ -279,7 +283,8 @@ static CURL *get_curl_handle(void)
> if (getenv("GIT_CURL_VERBOSE"))
> curl_easy_setopt(result, CURLOPT_VERBOSE, 1);
>
> - curl_easy_setopt(result, CURLOPT_USERAGENT, GIT_USER_AGENT);
> + curl_easy_setopt(result, CURLOPT_USERAGENT,
> + user_agent ? user_agent : GIT_USER_AGENT );
Excess space before ")".
>
> if (curl_ftp_no_epsv)
> curl_easy_setopt(result, CURLOPT_FTP_USE_EPSV, 0);
> @@ -380,6 +385,8 @@ void http_init(struct remote *remote)
> #endif
> set_from_env(&ssl_cainfo, "GIT_SSL_CAINFO");
>
> + set_from_env(&user_agent, "GIT_USER_AGENT");
The name GIT_USER_AGENT may be Ok as an internal token used in our http
implementation, but the environment variable is an end-user facing entity.
Don't we want to say HTTP somewhere, e.g. "GIT_HTTP_USER_AGENT"?
If "User Agent" means the "browser claims to be..." thing to everybody
without much context then I won't worry too much, but MUA is a mail user
agent, and we do use the term in our docs when describing send-email,
so...
next prev parent reply other threads:[~2010-08-11 20:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-07 3:34 [PATCH v2] Allow HTTP user agent string to be modified Spencer E. Olson
2010-08-07 8:34 ` Ævar Arnfjörð Bjarmason
2010-08-07 17:29 ` Spencer E. Olson
2010-08-07 17:39 ` Ævar Arnfjörð Bjarmason
2010-08-08 2:49 ` Tay Ray Chuan
2010-08-08 2:51 ` Tay Ray Chuan
2010-08-08 3:57 ` Spencer E. Olson
2010-08-11 5:24 ` [PATCH v3] " Spencer E. Olson
2010-08-11 8:04 ` Tay Ray Chuan
2010-08-11 20:08 ` Junio C Hamano [this message]
2010-08-11 20:32 ` [PATCH v4] " Spencer E. Olson
2010-08-11 20:35 ` Jacob Helwig
2010-08-11 20:40 ` [PATCH v5] " Spencer E. Olson
2010-08-12 17:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v62zgyks6.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lodatom@gmail.com \
--cc=nickh@reactrix.com \
--cc=olsonse@umich.edu \
--cc=rctay89@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).