From: "Spencer E. Olson" <olsonse@umich.edu>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: git@vger.kernel.org, Nick Hengeveld <nickh@reactrix.com>,
Mark Lodato <lodatom@gmail.com>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH v2] Allow HTTP user agent string to be modified.
Date: Sat, 07 Aug 2010 21:57:35 -0600 [thread overview]
Message-ID: <1281239855.7520.3.camel@compaq.olson.home> (raw)
In-Reply-To: <AANLkTi=G=GvxXEh1hGuYQK42cdkMUaFhqxsQ39K=2180@mail.gmail.com>
On Sun, 2010-08-08 at 10:51 +0800, Tay Ray Chuan wrote:
> > static char *user_name, *user_pass;
> > +static const char *user_agent = NULL;
>
> This can be skipped, I think.
My only reason for wanting to initialize is because I don't trust all
compilers to follow the standard. But, since there are so many other
instances of relying on the compiler to zero out static vars in other
places already, I don't have any problem with conforming...
>
> >[snip]
> > @@ -279,7 +283,10 @@ static CURL *get_curl_handle(void)
> > if (getenv("GIT_CURL_VERBOSE"))
> > curl_easy_setopt(result, CURLOPT_VERBOSE, 1);
> >
> > - curl_easy_setopt(result, CURLOPT_USERAGENT, GIT_USER_AGENT);
> > + if (user_agent != NULL)
> > + curl_easy_setopt(result, CURLOPT_USERAGENT, user_agent);
> > + else
> > + curl_easy_setopt(result, CURLOPT_USERAGENT, GIT_USER_AGENT);
>
> Hmm, perhaps
>
> curl_easy_setopt(result, CURLOPT_USERAGENT,
> user_agent ? user_agent : GIT_USER_AGENT);
>
> to replace the if-else?
That is perfectly fine with me.
next prev parent reply other threads:[~2010-08-08 3:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-07 3:34 [PATCH v2] Allow HTTP user agent string to be modified Spencer E. Olson
2010-08-07 8:34 ` Ævar Arnfjörð Bjarmason
2010-08-07 17:29 ` Spencer E. Olson
2010-08-07 17:39 ` Ævar Arnfjörð Bjarmason
2010-08-08 2:49 ` Tay Ray Chuan
2010-08-08 2:51 ` Tay Ray Chuan
2010-08-08 3:57 ` Spencer E. Olson [this message]
2010-08-11 5:24 ` [PATCH v3] " Spencer E. Olson
2010-08-11 8:04 ` Tay Ray Chuan
2010-08-11 20:08 ` Junio C Hamano
2010-08-11 20:32 ` [PATCH v4] " Spencer E. Olson
2010-08-11 20:35 ` Jacob Helwig
2010-08-11 20:40 ` [PATCH v5] " Spencer E. Olson
2010-08-12 17:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281239855.7520.3.camel@compaq.olson.home \
--to=olsonse@umich.edu \
--cc=git@vger.kernel.org \
--cc=lodatom@gmail.com \
--cc=nickh@reactrix.com \
--cc=rctay89@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).