From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [RFH/PATCH 0/4] git http tests with apache 2.4
Date: Fri, 14 Jun 2013 10:32:57 -0700 [thread overview]
Message-ID: <7v61xgpph2.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130609080722.GA31699@sigill.intra.peff.net> (Jeff King's message of "Sun, 9 Jun 2013 04:07:22 -0400")
Jeff King <peff@peff.net> writes:
> Apache 2.4 recently shipped in Debian unstable, and I noticed that all
> of the git httpd tests stopped working. It turns out that some
> configuration directives have changed between 2.2 and 2.4, and the httpd
> server would not start at all.
>
> With this series, the tests run again (for me, at least). The
> "<IfVersion>" checks hopefully mean that there are no regressions for
> people running 2.2 and lower.
>
> However, the final patch is very unsatisfactory. We have to pick an MPM
> module to mention in the config, but we don't have any idea what's
> available. I suspect what I have provided will work on most Unix-ish
> systems. Under Windows, there is a totally different MPM. But I am not
> sure that our http tests run at all on Windows, as we seem to check in
> lib-httpd.sh for a Unix-ish apache module path.
Thanks. I think the final one, while it may be unsatisfactory, is a
reasonable (or "least bad") compromise, at least for now. I do not
think of a better way, without adding "if you want customization,
write a snippet to be included in the configuration used during the
test", which feels way overkill.
>
> As far as I know, Apache does not have a "try to load this module and
> fallback" directive. We could perhaps look in the module directory and
> try to do something clever in the shell before starting Apache. Advice
> from Apache gurus is welcome.
>
> [1/4]: t/lib-httpd/apache.conf: do not use LockFile in apache >= 2.4
> [2/4]: t/lib-httpd/apache.conf: load extra auth modules in apache 2.4
> [3/4]: t/lib-httpd/apache.conf: load compat access module in apache 2.4
> [4/4]: t/lib-httpd/apache.conf: configure an MPM module for apache 2.4
>
> -Peff
next prev parent reply other threads:[~2013-06-14 17:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 8:07 [RFH/PATCH 0/4] git http tests with apache 2.4 Jeff King
2013-06-09 8:07 ` [PATCH 1/4] t/lib-httpd/apache.conf: do not use LockFile in apache >= 2.4 Jeff King
2013-06-09 8:08 ` [PATCH 2/4] t/lib-httpd/apache.conf: load extra auth modules in apache 2.4 Jeff King
2013-06-09 8:08 ` [PATCH 3/4] t/lib-httpd/apache.conf: load compat access module " Jeff King
2013-06-09 8:09 ` [PATCH 4/4] t/lib-httpd/apache.conf: configure an MPM module for " Jeff King
2013-06-14 17:32 ` Junio C Hamano [this message]
2013-06-14 21:58 ` [RFH/PATCH 0/4] git http tests with " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v61xgpph2.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).