git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [RFH/PATCH 0/4] git http tests with apache 2.4
Date: Fri, 14 Jun 2013 17:58:01 -0400	[thread overview]
Message-ID: <20130614215801.GC29138@sigill.intra.peff.net> (raw)
In-Reply-To: <7v61xgpph2.fsf@alter.siamese.dyndns.org>

On Fri, Jun 14, 2013 at 10:32:57AM -0700, Junio C Hamano wrote:

> > However, the final patch is very unsatisfactory. We have to pick an MPM
> > module to mention in the config, but we don't have any idea what's
> > available. I suspect what I have provided will work on most Unix-ish
> > systems. Under Windows, there is a totally different MPM. But I am not
> > sure that our http tests run at all on Windows, as we seem to check in
> > lib-httpd.sh for a Unix-ish apache module path.
> 
> Thanks.  I think the final one, while it may be unsatisfactory, is a
> reasonable (or "least bad") compromise, at least for now.  I do not
> think of a better way, without adding "if you want customization,
> write a snippet to be included in the configuration used during the
> test", which feels way overkill.

Yeah, we may have to go there. My feeling on it (and why I posted it
as-is) is that it improves the situation for some people, and should be
no worse for anyone else. Therefore people who are on 2.4 and are still
broken after this series can speak up and show us the exact breakage and
fix they need without us having to guess.

-Peff

      reply	other threads:[~2013-06-14 21:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-09  8:07 [RFH/PATCH 0/4] git http tests with apache 2.4 Jeff King
2013-06-09  8:07 ` [PATCH 1/4] t/lib-httpd/apache.conf: do not use LockFile in apache >= 2.4 Jeff King
2013-06-09  8:08 ` [PATCH 2/4] t/lib-httpd/apache.conf: load extra auth modules in apache 2.4 Jeff King
2013-06-09  8:08 ` [PATCH 3/4] t/lib-httpd/apache.conf: load compat access module " Jeff King
2013-06-09  8:09 ` [PATCH 4/4] t/lib-httpd/apache.conf: configure an MPM module for " Jeff King
2013-06-14 17:32 ` [RFH/PATCH 0/4] git http tests with " Junio C Hamano
2013-06-14 21:58   ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130614215801.GC29138@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).