From: <steve.norman@thomsonreuters.com>
To: <peff@peff.net>
Cc: <pclouds@gmail.com>, <git@vger.kernel.org>
Subject: RE: Troubleshoot clone issue to NFS.
Date: Fri, 5 Jun 2015 14:20:54 +0000 [thread overview]
Message-ID: <7FAE15F0A93C0144AD8B5FBD584E1C5519776893@C111KXTEMBX51.ERF.thomson.com> (raw)
In-Reply-To: <20150605121817.GA22125@peff.net>
On Friday, June 05, 2015 @ 1:18 PM Jeff King [mailto:peff@peff.net] did scribble:
> Sorry, I haven't had a chance to look at it further. It still on my todo
> list. My plan is:
>
> 1. Devise some torture to tests to see whether my patch series is in
> fact racy on Linux.
>
> 2. Assuming it is, scrap it and make a has_sha1_file_quick() which
> might sometimes return a false negative (if somebody else is
> repacking). Use that in index-pack (and possibly other places, but
> we can start with index-pack).
>
> If we skip step 1 out of pessimism (which I think is a reasonable thing
> to do), then step 2 should not be all that much work. I'm going to be
> offline for a few days, though, so I won't get to it until next week at
> the earliest. If you (or someone else) wants to take a stab at it,
> please feel free.
I've been off myself and wanted to make sure I hadn't missed anything in
the email threads while I was away as there we rather a lot of them.
Not feeling confident enough to make the changes myself at the moment.
I think what you are saying is that has_sha1_file_quick() would be the version
from before your change in 45e8a74. And then use that, but I could be
barking up the wrong tree completely.
Thanks,
Steve
next prev parent reply other threads:[~2015-06-05 14:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 13:13 Troubleshoot clone issue to NFS steve.norman
2015-05-21 14:00 ` Christian Couder
2015-05-21 14:31 ` Duy Nguyen
2015-05-21 14:38 ` Duy Nguyen
2015-05-21 15:53 ` steve.norman
2015-05-22 0:16 ` Duy Nguyen
2015-05-22 7:12 ` Jeff King
2015-05-22 8:35 ` steve.norman
2015-05-22 10:05 ` Duy Nguyen
2015-05-22 14:37 ` Junio C Hamano
2015-05-22 15:02 ` steve.norman
2015-05-22 23:51 ` [PATCH/RFC 0/3] using stat() to avoid re-scanning pack dir Jeff King
2015-05-22 23:51 ` [PATCH 1/3] stat_validity: handle non-regular files Jeff King
2015-05-23 11:00 ` Michael Haggerty
2015-05-24 8:29 ` Jeff King
2015-05-22 23:52 ` [PATCH 2/3] cache.h: move stat_validity definition up Jeff King
2015-05-22 23:54 ` [PATCH 3/3] prepare_packed_git: use stat_validity to avoid re-reading packs Jeff King
2015-05-23 1:19 ` [PATCH/RFC 0/3] using stat() to avoid re-scanning pack dir Duy Nguyen
2015-05-23 1:21 ` Duy Nguyen
2015-05-24 8:20 ` Jeff King
2015-05-24 9:00 ` Troubleshoot clone issue to NFS Duy Nguyen
2015-06-05 12:01 ` steve.norman
2015-06-05 12:18 ` Jeff King
2015-06-05 12:29 ` [PATCH] index-pack: avoid excessive re-reading of pack directory Jeff King
2015-06-09 17:24 ` Jeff King
2015-06-09 17:41 ` Jeff King
2015-06-10 3:46 ` Shawn Pearce
2015-06-10 14:00 ` Jeff King
2015-06-10 14:36 ` Duy Nguyen
2015-06-10 21:34 ` Shawn Pearce
2015-06-05 14:20 ` steve.norman [this message]
2015-06-16 20:50 ` Troubleshoot clone issue to NFS Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7FAE15F0A93C0144AD8B5FBD584E1C5519776893@C111KXTEMBX51.ERF.thomson.com \
--to=steve.norman@thomsonreuters.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).