From: "René Scharfe" <l.s.r@web.de>
To: "Dipl. Ing. Sergey Brester" <serg.brester@sebres.de>,
Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, "brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: git fast-import leaks memory drastically, so crashes with out of memory by attempt to import 22MB export dump
Date: Thu, 15 Oct 2020 17:52:27 +0200 [thread overview]
Message-ID: <79cbeb4c-5840-d5b7-a2b9-d72cf47968df@web.de> (raw)
In-Reply-To: <72a4d4d8dff95351122bd192976dd6b1@sebres.de>
Am 15.10.20 um 13:50 schrieb Dipl. Ing. Sergey Brester:
> ```
> # clone or copy git repository (we'll use it for export and import):
> git clone https://github.com/git/git.git
> cd git
>
> # make 1st fast-export in order to generate marks (don't need the dump, only marks are needed):
> git fast-export --reencode=yes --export-marks=.tmp.exp-1.tmp e83c5163316f89bfbde7d9ab23ca2e25604af290..dc04167d378fb29d30e1647ff6ff51dd182bc9a3 > /dev/null
>
> # make 2nd fast-export in order to generate partial export dump (file ".tmp.dump" will be ca. 87MB):
> git fast-export --reencode=yes --import-marks=.tmp.exp-1.tmp --export-marks=.tmp.exp-2.tmp 61addb841f2a6d74a1737a01e03df1f773e04944..master > .tmp.dump
In case someone else is wondering about the meaning of those hashes,
here are their reference strings:
e83c516331 (Initial revision of "git", the information manager from hell, 2005-04-07)
dc04167d37 (Fourth batch, 2020-08-04)
61addb841f (Merge branch 'jk/strvec' into next, 2020-08-04)
> # now try to import this dump, using first marks as import marks (we have all revs in git-repo):
> git fast-import --import-marks=.tmp.exp-1.tmp --export-marks=.tmp.imp.tmp < .tmp.dump
>
> ```
So you use the marks generated by the first export to import the second
export. I wonder if that's relevant to trigger the memory allocation
issue.
> And see how git-fast-import eating your whole memory and enjoy the crash :)
>
> ```
> fatal: Out of memory, malloc failed (tried to allocate 2097152 bytes)
> fast-import: dumping crash report to .git/fast_import_crash_6684
> ```
I can reproduce this on Debian -- but don't get a crash report, just a
notice from the OOM killer. It bisects to ddddf8d7e2 (fast-import:
permit reading multiple marks files, 2020-02-22).
René
next prev parent reply other threads:[~2020-10-15 15:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 9:22 git fast-import leaks memory drastically, so crashes with out of memory by attempt to import 22MB export dump Dipl. Ing. Sergey Brester
2020-10-15 1:26 ` Jeff King
2020-10-15 11:50 ` Dipl. Ing. Sergey Brester
2020-10-15 15:38 ` [PATCH] fast-import: fix over-allocation of marks storage Jeff King
2020-10-15 17:29 ` Junio C Hamano
2020-10-15 17:34 ` Junio C Hamano
2020-10-15 18:09 ` Dipl. Ing. Sergey Brester
2020-10-15 18:35 ` Junio C Hamano
2020-10-15 18:58 ` Jeff King
2020-10-15 19:13 ` Junio C Hamano
2020-10-16 2:37 ` brian m. carlson
2020-10-15 19:05 ` Jeff King
2020-10-15 19:06 ` Jeff King
2020-10-16 3:18 ` brian m. carlson
2020-10-16 20:25 ` Jeff King
2020-10-15 19:17 ` Dipl. Ing. Sergey Brester
2020-10-15 20:15 ` Junio C Hamano
2020-10-15 17:57 ` René Scharfe
2020-10-15 15:52 ` René Scharfe [this message]
2020-10-15 16:19 ` git fast-import leaks memory drastically, so crashes with out of memory by attempt to import 22MB export dump Dipl. Ing. Sergey Brester
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79cbeb4c-5840-d5b7-a2b9-d72cf47968df@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=serg.brester@sebres.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).