From: "Dipl. Ing. Sergey Brester" <serg.brester@sebres.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org
Subject: Re: [PATCH] fast-import: fix over-allocation of marks storage
Date: Thu, 15 Oct 2020 20:09:47 +0200 [thread overview]
Message-ID: <f3e4f7ccc36dc214201c1838acce4aff@sebres.de> (raw)
In-Reply-To: <xmqqv9fbfl68.fsf@gitster.c.googlers.com>
Nice.
Brian's patch looks indeed really similar.
May be this is a sign to introduce real issue tracker finally? :)
No offence, but I was always wondering how a team is able to hold all
the issue related stuff in form
of a mailing list, without to experience such an "embarrassments".
Especially on such large projects and communities.
Regards,
Sergey
15.10.2020 19:34, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Why does this vaguely look familiar, I wonder. I can swear that we saw
>> a breakage due to a similar pattern that attempts to convert a global
>> to an arg that is passed down to the callchain but not doing so fully.
>
> Are we revisiting this thread?
>
> https://lore.kernel.org/git/xmqqtuzlld1d.fsf@gitster.c.googlers.com/
> [1]
>
> I wonder what happend to the thread at the end ...
>
>> Anyway, the diagnoses above look correct and cleanly described. Will
>> queue. Thanks.
Links:
------
[1] https://lore.kernel.org/git/xmqqtuzlld1d.fsf@gitster.c.googlers.com/
next prev parent reply other threads:[~2020-10-15 18:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 9:22 git fast-import leaks memory drastically, so crashes with out of memory by attempt to import 22MB export dump Dipl. Ing. Sergey Brester
2020-10-15 1:26 ` Jeff King
2020-10-15 11:50 ` Dipl. Ing. Sergey Brester
2020-10-15 15:38 ` [PATCH] fast-import: fix over-allocation of marks storage Jeff King
2020-10-15 17:29 ` Junio C Hamano
2020-10-15 17:34 ` Junio C Hamano
2020-10-15 18:09 ` Dipl. Ing. Sergey Brester [this message]
2020-10-15 18:35 ` Junio C Hamano
2020-10-15 18:58 ` Jeff King
2020-10-15 19:13 ` Junio C Hamano
2020-10-16 2:37 ` brian m. carlson
2020-10-15 19:05 ` Jeff King
2020-10-15 19:06 ` Jeff King
2020-10-16 3:18 ` brian m. carlson
2020-10-16 20:25 ` Jeff King
2020-10-15 19:17 ` Dipl. Ing. Sergey Brester
2020-10-15 20:15 ` Junio C Hamano
2020-10-15 17:57 ` René Scharfe
2020-10-15 15:52 ` git fast-import leaks memory drastically, so crashes with out of memory by attempt to import 22MB export dump René Scharfe
2020-10-15 16:19 ` Dipl. Ing. Sergey Brester
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3e4f7ccc36dc214201c1838acce4aff@sebres.de \
--to=serg.brester@sebres.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).