From: "Mkrtchyan, Tigran" <tigran.mkrtchyan@desy.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] tag: add tag.gpgSign config option to force all tags be GPG-signed
Date: Fri, 27 Oct 2017 09:41:14 +0200 (CEST) [thread overview]
Message-ID: <760741736.3439901.1509090074292.JavaMail.zimbra@desy.de> (raw)
In-Reply-To: <20171026213337.kbmwnaxlsyubat4w@aiede.mtv.corp.google.com>
Hi Jonathan,
I can't disagree with you - the right solution is to fix the build/release process to support
signed tagging. It's just too many of them to fix: jenkins, maven, IDE, etc. My naive assumption
was that if a tool (git) has a switch to enable some functionality, why not have a possibility
to make it default.
You can put this change on hold and re-consider it if more people will need such functionality.
Thanks,
Tigran.
----- Original Message -----
> From: "Jonathan Nieder" <jrnieder@gmail.com>
> To: "Tigran Mkrtchyan" <tigran.mkrtchyan@desy.de>
> Cc: "git" <git@vger.kernel.org>
> Sent: Thursday, October 26, 2017 11:33:37 PM
> Subject: Re: [PATCH] tag: add tag.gpgSign config option to force all tags be GPG-signed
> Hi again,
>
> Mkrtchyan, Tigran wrote:
>> Jonathan Nieder wrote:
>>> Tigran Mkrtchyan wrote:
>
>>>> In some workflows we have no control on how git command is executed,
>>>> however a signed tags are required.
>>>
>>> Don't leave me hanging: this leaves me super curious. Can you tell me
>>> more about these workflows?
>>
>> Well, this is a build/release process where we can't pass additional
>> command line options to git. TO be hones, is case of annotated tags
>> there is already option tag.forceSignAnnotated. However, non annotated
>> tags are not forced to be signed.
>>
>> Additionally, the proposed option is symmetric with commit.gpgSign.
>
> Now I'm even more curious.
>
> I don't think we have the full picture to understand whether this
> change is needed. When adding a configuration item, we need to be
> able to explain to users what the configuration item is for, and so
> far the only answer I am hearing is "because we do not want to patch
> our build/release script, though we could in principle". That doesn't
> sound like a compelling reason.
>
> On the other hand, perhaps the answer is "our build/release script
> does not have a --sign option for the following reason, and this is a
> better interface for configuring it".
>
> Or perhaps there is an answer that does not involve the build/release
> script.
>
> But with no answer at all, it is hard to see why we should move
> forward on this patch.
>
> To be clear, I am not saying that writing the patch is wasted effort.
> E.g. you can continue to use it internally, and it means that once we
> have a clear reason to add this configuration, the patch is there and
> ready to use to do so.
>
> Thanks again,
> Jonathan
next prev parent reply other threads:[~2017-10-27 7:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 19:55 [PATCH] tag: add tag.gpgSign config option to force all tags be GPG-signed Tigran Mkrtchyan
2017-10-26 20:55 ` Jonathan Nieder
2017-10-26 21:01 ` Mkrtchyan, Tigran
2017-10-26 21:33 ` Jonathan Nieder
2017-10-26 21:45 ` Stefan Beller
2017-10-27 7:41 ` Mkrtchyan, Tigran [this message]
2017-10-28 17:17 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=760741736.3439901.1509090074292.JavaMail.zimbra@desy.de \
--to=tigran.mkrtchyan@desy.de \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).