From: Andrei Rybak <rybak.a.v@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Øystein Walle" <oystwa@gmail.com>
Subject: Re: [PATCH v3 0/6] t: fix unused files, part 2
Date: Tue, 2 May 2023 23:03:36 +0200 [thread overview]
Message-ID: <73ead9f4-4e12-09c6-8abb-e338f71efceb@gmail.com> (raw)
In-Reply-To: <xmqq8re74t3j.fsf@gitster.g>
On 01/05/2023 23:52, Junio C Hamano wrote:
> Andrei Rybak <rybak.a.v@gmail.com> writes:
>
>> Creation of files from redirecting output of Git commands in tests has been
>> removed for files which aren't being used for assertions. CC'ed are authors of
>> the affected tests.
>>
>> v1 cover letter:
>> https://lore.kernel.org/git/20230401212858.266508-1-rybak.a.v@gmail.com/
>> v2 cover letter:
>> https://lore.kernel.org/git/20230403223338.468025-1-rybak.a.v@gmail.com/
>
> This round has not seen any further comments; shall we consider it
> pretty much done and ready to move to 'next' by now?
In general, I'm OK with the series as is.
While answering Ævar's questions to some of the patches in v2, I
went quite deep in trying to investigate what is and isn't important
to validate/assert in particular tests, but I haven't come up with
a good way to include this information in commit messages for this
series.
Notes per patch:
- 1/6 for t0300 is just an explanation about why one out of three
cases in one test does not check stdout (and doesn't need to).
https://lore.kernel.org/git/db2de983-9b1f-5efb-0fdc-cc704e6b875b@gmail.com/
- 3/6 for t1300 lead to a separate series
https://lore.kernel.org/git/20230423134649.431783-1-rybak.a.v@gmail.com/
- 4/6 for t1450 had an idea for a test 'fresh repository has no
dangling objects'. I'm doubtful about usefulness of such a test,
so hasn't sent it as a patch yet.
https://lore.kernel.org/git/35bc2dc5-d5cb-3492-ff94-41b93b7563d4@gmail.com/
- 6/6 for t2019 -- a dive into how output of "git checkout" is tested
https://lore.kernel.org/git/4ef5464b-31dd-3c3e-05be-9891162e4f05@gmail.com/#t
Patches 2/6 and 5/6 are different from others, because they fix
more obvious issues.
> Thanks.
next prev parent reply other threads:[~2023-05-02 21:04 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 21:28 [PATCH v1 0/6] t: fix unused files, part 2 Andrei Rybak
2023-04-01 21:28 ` [PATCH v1 1/6] t0300: don't create unused file Andrei Rybak
2023-04-02 1:30 ` Eric Sunshine
2023-04-01 21:28 ` [PATCH v1 2/6] t1300: fix config file syntax error descriptions Andrei Rybak
2023-04-01 21:28 ` [PATCH v1 3/6] t1300: don't create unused files Andrei Rybak
2023-04-01 21:28 ` [PATCH v1 4/6] t1450: " Andrei Rybak
2023-04-01 21:28 ` [PATCH v1 5/6] t1502: " Andrei Rybak
2023-04-01 21:28 ` [PATCH v1 6/6] t2019: " Andrei Rybak
2023-04-03 22:33 ` [PATCH v2 0/6] t: fix unused files, part 2 Andrei Rybak
2023-04-03 22:33 ` [PATCH v2 1/6] t0300: don't create unused file Andrei Rybak
2023-04-06 8:34 ` Ævar Arnfjörð Bjarmason
2023-04-06 21:01 ` Andrei Rybak
2023-04-03 22:33 ` [PATCH v2 2/6] t1300: fix config file syntax error descriptions Andrei Rybak
2023-04-03 22:33 ` [PATCH v2 3/6] t1300: don't create unused files Andrei Rybak
2023-04-06 8:38 ` Ævar Arnfjörð Bjarmason
2023-04-06 21:30 ` Andrei Rybak
2023-04-06 21:35 ` git config tests for "'git config ignores pairs ..." (was Re: [PATCH v2 3/6] t1300: don't create unused files) Andrei Rybak
2023-04-14 8:13 ` [PATCH v1 0/2] git config tests for "'git config ignores pairs ..." Andrei Rybak
2023-04-14 8:13 ` [PATCH v1 1/2] t1300: drop duplicate test Andrei Rybak
2023-04-14 8:13 ` [PATCH v1 2/2] t1300: check stderr for "ignores pairs" tests Andrei Rybak
2023-04-14 13:28 ` Andrei Rybak
2023-04-18 17:50 ` [PATCH v2 0/3] git config tests for "'git config ignores pairs ..." Andrei Rybak
2023-04-18 17:50 ` [PATCH v2 1/3] t1300: drop duplicate test Andrei Rybak
2023-04-18 18:37 ` Junio C Hamano
2023-04-18 17:50 ` [PATCH v2 2/3] t1300: check stderr for "ignores pairs" tests Andrei Rybak
2023-04-18 18:39 ` Junio C Hamano
2023-04-18 17:50 ` [RFC PATCH v2 3/3] t1300: add tests for missing keys Andrei Rybak
2023-04-18 19:31 ` Junio C Hamano
2023-04-18 17:53 ` [PATCH v2 0/3] git config tests for "'git config ignores pairs ..." Andrei Rybak
2023-04-23 13:46 ` [PATCH v3 " Andrei Rybak
2023-04-23 13:46 ` [PATCH v3 1/3] t1300: drop duplicate test Andrei Rybak
2023-04-23 13:46 ` [PATCH v3 2/3] t1300: check stderr for "ignores pairs" tests Andrei Rybak
2023-04-23 13:46 ` [PATCH v3 3/3] t1300: add tests for missing keys Andrei Rybak
2023-05-01 22:02 ` [PATCH v3 0/3] git config tests for "'git config ignores pairs ..." Junio C Hamano
2023-05-02 19:58 ` Andrei Rybak
2023-04-03 22:33 ` [PATCH v2 4/6] t1450: don't create unused files Andrei Rybak
2023-04-06 8:41 ` Ævar Arnfjörð Bjarmason
2023-04-06 22:19 ` Andrei Rybak
2023-04-03 22:33 ` [PATCH v2 5/6] t1502: " Andrei Rybak
2023-04-06 8:15 ` Øystein Walle
2023-04-06 8:47 ` Ævar Arnfjörð Bjarmason
2023-04-06 19:51 ` Andrei Rybak
2023-04-03 22:33 ` [PATCH v2 6/6] t2019: " Andrei Rybak
2023-04-06 8:44 ` Ævar Arnfjörð Bjarmason
2023-04-07 2:19 ` Andrei Rybak
2023-04-08 20:54 ` [PATCH] t2024: fix loose/strict local base branch DWIM test Andrei Rybak
2023-04-10 17:37 ` Junio C Hamano
2023-04-17 19:10 ` [PATCH v3 0/6] t: fix unused files, part 2 Andrei Rybak
2023-04-17 19:10 ` [PATCH v3 1/6] t0300: don't create unused file Andrei Rybak
2023-04-17 19:10 ` [PATCH v3 2/6] t1300: fix config file syntax error descriptions Andrei Rybak
2023-04-17 19:10 ` [PATCH v3 3/6] t1300: don't create unused files Andrei Rybak
2023-04-17 19:10 ` [PATCH v3 4/6] t1450: " Andrei Rybak
2023-04-17 19:10 ` [PATCH v3 5/6] t1502: " Andrei Rybak
2023-04-17 19:10 ` [PATCH v3 6/6] t2019: " Andrei Rybak
2023-05-01 21:52 ` [PATCH v3 0/6] t: fix unused files, part 2 Junio C Hamano
2023-05-02 21:03 ` Andrei Rybak [this message]
2023-05-03 4:11 ` Elijah Newren
2023-05-03 15:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73ead9f4-4e12-09c6-8abb-e338f71efceb@gmail.com \
--to=rybak.a.v@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=oystwa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).