From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Andrei Rybak <rybak.a.v@gmail.com>
Cc: git@vger.kernel.org,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Øystein Walle" <oystwa@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v2 5/6] t1502: don't create unused files
Date: Thu, 06 Apr 2023 10:47:43 +0200 [thread overview]
Message-ID: <230406.86cz4htmzz.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <20230403223338.468025-6-rybak.a.v@gmail.com>
On Tue, Apr 04 2023, Andrei Rybak wrote:
> Three tests in file t1502-rev-parse-parseopt.sh use three redirections
> with invocation of "git rev-parse --parseopt --". All three tests
> redirect standard output to file "out" and file "spec" to standard
> input. Two of the tests redirect standard output a second time to file
> "actual", and the third test redirects standard error to file "err".
> These tests check contents of files "actual" and "err", but don't use
> the files named "out" for assertions. The two tests that redirect to
> standard output twice might also be confusing to the reader.
>
> Don't redirect standard output of "git rev-parse" to file "out" in
> t1502-rev-parse-parseopt.sh to avoid creating unnecessary files.
>
> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
> ---
> t/t1502-rev-parse-parseopt.sh | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/t/t1502-rev-parse-parseopt.sh b/t/t1502-rev-parse-parseopt.sh
> index de1d48f3ba..dd811b7fb4 100755
> --- a/t/t1502-rev-parse-parseopt.sh
> +++ b/t/t1502-rev-parse-parseopt.sh
> @@ -302,14 +302,14 @@ test_expect_success 'test --parseopt help output: "wrapped" options normal "or:"
> |EOF
> END_EXPECT
>
> - test_must_fail git rev-parse --parseopt -- -h >out <spec >actual &&
> + test_must_fail git rev-parse --parseopt -- -h <spec >actual &&
> test_cmp expect actual
> '
>
> test_expect_success 'test --parseopt invalid opt-spec' '
> test_write_lines x -- "=, x" >spec &&
> echo "fatal: missing opt-spec before option flags" >expect &&
> - test_must_fail git rev-parse --parseopt -- >out <spec 2>err &&
> + test_must_fail git rev-parse --parseopt -- <spec 2>err &&
> test_cmp expect err
> '
>
> @@ -339,7 +339,7 @@ test_expect_success 'test --parseopt help output: multi-line blurb after empty l
> |EOF
> END_EXPECT
>
> - test_must_fail git rev-parse --parseopt -- -h >out <spec >actual &&
> + test_must_fail git rev-parse --parseopt -- -h <spec >actual &&
> test_cmp expect actual
> '
Ditto earlier comments: When we fail, we should assert what we emitted
on stdout, surely this should also be a "test_must_be_empty out".
(I didn't test that, but if that fails wes hould be testing whatever it
is that we emit here, surely..)
next prev parent reply other threads:[~2023-04-06 8:49 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 21:28 [PATCH v1 0/6] t: fix unused files, part 2 Andrei Rybak
2023-04-01 21:28 ` [PATCH v1 1/6] t0300: don't create unused file Andrei Rybak
2023-04-02 1:30 ` Eric Sunshine
2023-04-01 21:28 ` [PATCH v1 2/6] t1300: fix config file syntax error descriptions Andrei Rybak
2023-04-01 21:28 ` [PATCH v1 3/6] t1300: don't create unused files Andrei Rybak
2023-04-01 21:28 ` [PATCH v1 4/6] t1450: " Andrei Rybak
2023-04-01 21:28 ` [PATCH v1 5/6] t1502: " Andrei Rybak
2023-04-01 21:28 ` [PATCH v1 6/6] t2019: " Andrei Rybak
2023-04-03 22:33 ` [PATCH v2 0/6] t: fix unused files, part 2 Andrei Rybak
2023-04-03 22:33 ` [PATCH v2 1/6] t0300: don't create unused file Andrei Rybak
2023-04-06 8:34 ` Ævar Arnfjörð Bjarmason
2023-04-06 21:01 ` Andrei Rybak
2023-04-03 22:33 ` [PATCH v2 2/6] t1300: fix config file syntax error descriptions Andrei Rybak
2023-04-03 22:33 ` [PATCH v2 3/6] t1300: don't create unused files Andrei Rybak
2023-04-06 8:38 ` Ævar Arnfjörð Bjarmason
2023-04-06 21:30 ` Andrei Rybak
2023-04-06 21:35 ` git config tests for "'git config ignores pairs ..." (was Re: [PATCH v2 3/6] t1300: don't create unused files) Andrei Rybak
2023-04-14 8:13 ` [PATCH v1 0/2] git config tests for "'git config ignores pairs ..." Andrei Rybak
2023-04-14 8:13 ` [PATCH v1 1/2] t1300: drop duplicate test Andrei Rybak
2023-04-14 8:13 ` [PATCH v1 2/2] t1300: check stderr for "ignores pairs" tests Andrei Rybak
2023-04-14 13:28 ` Andrei Rybak
2023-04-18 17:50 ` [PATCH v2 0/3] git config tests for "'git config ignores pairs ..." Andrei Rybak
2023-04-18 17:50 ` [PATCH v2 1/3] t1300: drop duplicate test Andrei Rybak
2023-04-18 18:37 ` Junio C Hamano
2023-04-18 17:50 ` [PATCH v2 2/3] t1300: check stderr for "ignores pairs" tests Andrei Rybak
2023-04-18 18:39 ` Junio C Hamano
2023-04-18 17:50 ` [RFC PATCH v2 3/3] t1300: add tests for missing keys Andrei Rybak
2023-04-18 19:31 ` Junio C Hamano
2023-04-18 17:53 ` [PATCH v2 0/3] git config tests for "'git config ignores pairs ..." Andrei Rybak
2023-04-23 13:46 ` [PATCH v3 " Andrei Rybak
2023-04-23 13:46 ` [PATCH v3 1/3] t1300: drop duplicate test Andrei Rybak
2023-04-23 13:46 ` [PATCH v3 2/3] t1300: check stderr for "ignores pairs" tests Andrei Rybak
2023-04-23 13:46 ` [PATCH v3 3/3] t1300: add tests for missing keys Andrei Rybak
2023-05-01 22:02 ` [PATCH v3 0/3] git config tests for "'git config ignores pairs ..." Junio C Hamano
2023-05-02 19:58 ` Andrei Rybak
2023-04-03 22:33 ` [PATCH v2 4/6] t1450: don't create unused files Andrei Rybak
2023-04-06 8:41 ` Ævar Arnfjörð Bjarmason
2023-04-06 22:19 ` Andrei Rybak
2023-04-03 22:33 ` [PATCH v2 5/6] t1502: " Andrei Rybak
2023-04-06 8:15 ` Øystein Walle
2023-04-06 8:47 ` Ævar Arnfjörð Bjarmason [this message]
2023-04-06 19:51 ` Andrei Rybak
2023-04-03 22:33 ` [PATCH v2 6/6] t2019: " Andrei Rybak
2023-04-06 8:44 ` Ævar Arnfjörð Bjarmason
2023-04-07 2:19 ` Andrei Rybak
2023-04-08 20:54 ` [PATCH] t2024: fix loose/strict local base branch DWIM test Andrei Rybak
2023-04-10 17:37 ` Junio C Hamano
2023-04-17 19:10 ` [PATCH v3 0/6] t: fix unused files, part 2 Andrei Rybak
2023-04-17 19:10 ` [PATCH v3 1/6] t0300: don't create unused file Andrei Rybak
2023-04-17 19:10 ` [PATCH v3 2/6] t1300: fix config file syntax error descriptions Andrei Rybak
2023-04-17 19:10 ` [PATCH v3 3/6] t1300: don't create unused files Andrei Rybak
2023-04-17 19:10 ` [PATCH v3 4/6] t1450: " Andrei Rybak
2023-04-17 19:10 ` [PATCH v3 5/6] t1502: " Andrei Rybak
2023-04-17 19:10 ` [PATCH v3 6/6] t2019: " Andrei Rybak
2023-05-01 21:52 ` [PATCH v3 0/6] t: fix unused files, part 2 Junio C Hamano
2023-05-02 21:03 ` Andrei Rybak
2023-05-03 4:11 ` Elijah Newren
2023-05-03 15:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=230406.86cz4htmzz.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=oystwa@gmail.com \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).