git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: douglas.fuller@gmail.com
To: git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net
Subject: [PATCH] doc: fix quoting bug in credential cache example
Date: Thu, 30 Apr 2020 10:36:47 -0400	[thread overview]
Message-ID: <63f35287c9ced4d674f938bedd439aefa6c46f41.camel@gmail.com> (raw)

Unquoted semicolons are considered shell argument separators, quote
them so the example works correctly.

Signed-off-by: Douglas Fuller <douglas.fuller@gmail.com>
---
 Documentation/gitcredentials.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/gitcredentials.txt
b/Documentation/gitcredentials.txt
index 1814d2d23c..fb16c71cfe 100644
--- a/Documentation/gitcredentials.txt
+++ b/Documentation/gitcredentials.txt
@@ -229,7 +229,7 @@ foo --bar="whitespace arg"
 /path/to/my/helper --with-arguments
 
 # or you can specify your own shell snippet
-!f() { echo "password=`cat $HOME/.secret`"; }; f
+"!f() { echo password=`cat $HOME/.secret`; }; f"
 ----------------------------------------------------
 
 Generally speaking, rule (3) above is the simplest for users to
specify.
-- 
2.26.2



             reply	other threads:[~2020-04-30 14:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 14:36 douglas.fuller [this message]
2020-04-30 18:09 ` [PATCH] doc: fix quoting bug in credential cache example Junio C Hamano
2020-05-01  5:57   ` Jeff King
2020-05-01  6:19     ` Jeff King
2020-05-01  6:20       ` [PATCH 1/2] gitcredentials(7): clarify quoting of helper examples Jeff King
2020-05-01  7:19         ` Andreas Schwab
2020-05-01  7:31           ` Jeff King
2020-05-01  6:23       ` [PATCH 2/2] gitcredentials(7): make shell-snippet example more realistic Jeff King
2020-05-01  6:26         ` Junio C Hamano
2020-05-01  6:32           ` Jeff King
2020-05-01  6:35             ` Jeff King
2020-05-01  7:32               ` Jeff King
2020-05-01  7:33                 ` [PATCH v2 1/2] gitcredentials(7): clarify quoting of helper examples Jeff King
2020-05-01  7:33                 ` [PATCH v2 2/2] gitcredentials(7): make shell-snippet example more realistic Jeff King
2020-05-01 15:11               ` [PATCH " Junio C Hamano
2020-05-01 14:40       ` [PATCH] doc: fix quoting bug in credential cache example douglas.fuller
2020-05-01  6:20     ` Junio C Hamano
2020-05-01  6:25       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63f35287c9ced4d674f938bedd439aefa6c46f41.camel@gmail.com \
    --to=douglas.fuller@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).