From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: douglas.fuller@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH 2/2] gitcredentials(7): make shell-snippet example more realistic
Date: Fri, 1 May 2020 03:32:22 -0400 [thread overview]
Message-ID: <20200501073222.GB27392@coredump.intra.peff.net> (raw)
In-Reply-To: <20200501063513.GB26128@coredump.intra.peff.net>
On Fri, May 01, 2020 at 02:35:13AM -0400, Jeff King wrote:
> On Fri, May 01, 2020 at 02:32:07AM -0400, Jeff King wrote:
>
> > > All of them make sense, but I do not think we want to encourage that
> > > loose style of passing unquoted argument to echo to lose embedded
> > > $IFS spaces that is not a SP.
> >
> > You mean dropping the quotes in the first patch?
> >
> > Doing:
> >
> > echo "password=$(cat $HOME/.secret)"
> >
> > already eats some trailing whitespace, though I guess if you have
> > newlines in your password you are beyond help anyway.
> >
> > I can add back in the quoted \", though it does make the code slightly
> > harder to read.
>
> Or did you mean passing $1 in the test call? It definitely isn't good
> shell practice, but we know that we're getting a single-word action from
> Git, per the protocol.
>
> Fully quoting, it looks like this:
>
> helper = "!f() { test \"$1\" = get && echo \"password=$(cat $HOME/.secret)\"; }; f"
>
> which IMHO is getting a little hard to read. I think that's part of why
> I gave such an unfinished example in the first place. :)
So I dunno. That's ugly, but I don't think is worth nitpicking over
more. So here it is with indentation and full-on quoting.
[1/2]: gitcredentials(7): clarify quoting of helper examples
[2/2]: gitcredentials(7): make shell-snippet example more realistic
Documentation/gitcredentials.txt | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
-Peff
next prev parent reply other threads:[~2020-05-01 7:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 14:36 [PATCH] doc: fix quoting bug in credential cache example douglas.fuller
2020-04-30 18:09 ` Junio C Hamano
2020-05-01 5:57 ` Jeff King
2020-05-01 6:19 ` Jeff King
2020-05-01 6:20 ` [PATCH 1/2] gitcredentials(7): clarify quoting of helper examples Jeff King
2020-05-01 7:19 ` Andreas Schwab
2020-05-01 7:31 ` Jeff King
2020-05-01 6:23 ` [PATCH 2/2] gitcredentials(7): make shell-snippet example more realistic Jeff King
2020-05-01 6:26 ` Junio C Hamano
2020-05-01 6:32 ` Jeff King
2020-05-01 6:35 ` Jeff King
2020-05-01 7:32 ` Jeff King [this message]
2020-05-01 7:33 ` [PATCH v2 1/2] gitcredentials(7): clarify quoting of helper examples Jeff King
2020-05-01 7:33 ` [PATCH v2 2/2] gitcredentials(7): make shell-snippet example more realistic Jeff King
2020-05-01 15:11 ` [PATCH " Junio C Hamano
2020-05-01 14:40 ` [PATCH] doc: fix quoting bug in credential cache example douglas.fuller
2020-05-01 6:20 ` Junio C Hamano
2020-05-01 6:25 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501073222.GB27392@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=douglas.fuller@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).