From: Jeff Hostetler <git@jeffhostetler.com>
To: "René Scharfe" <l.s.r@web.de>, git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v5 1/4] p0004-read-tree: perf test to time read-tree
Date: Thu, 6 Apr 2017 16:41:03 -0400 [thread overview]
Message-ID: <6286a37f-aa22-ff70-3127-c417a6920c35@jeffhostetler.com> (raw)
In-Reply-To: <6937b76e-9bbf-7ce5-8605-e09f556f8a26@web.de>
On 4/6/2017 4:20 PM, René Scharfe wrote:
> Am 05.04.2017 um 19:38 schrieb git@jeffhostetler.com:
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
>> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
>> ---
>> t/perf/p0004-read-tree.sh | 116 ++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 116 insertions(+)
>> create mode 100755 t/perf/p0004-read-tree.sh
>>
>> diff --git a/t/perf/p0004-read-tree.sh b/t/perf/p0004-read-tree.sh
>> new file mode 100755
>> index 0000000..5d8bbf5
>> --- /dev/null
>> +++ b/t/perf/p0004-read-tree.sh
>> @@ -0,0 +1,116 @@
>> +#!/bin/sh
>> +
>> +test_description="Tests performance of read-tree"
>> +
>> +. ./perf-lib.sh
>> +
>> +test_perf_default_repo
>> +test_checkout_worktree
>> +
>> +## usage: dir depth width files
>> +make_paths () {
>> + for f in $(seq $4)
>> + do
>> + echo $1/file$f
>> + done;
>> + if test $2 -gt 0;
>> + then
>> + for w in $(seq $3)
>> + do
>> + make_paths $1/dir$w $(($2 - 1)) $3 $4
>> + done
>> + fi
>> + return 0
>> +}
>
> "make_paths xxx_dir_xxx 5 10 9" takes more than a minute for me.
> Providing its results as a file would be quicker but less flexible.
> The following command prints the same result in less than a second.
>
> awk -v dir=xxx_dir_xxx -v depth=5 -v width=10 -v files=9 '
> function make_paths(dir, depth, width, files, i)
> {
> for (i = 1; i <= files; i++) {
> print dir "/file" i
> }
> if (depth > 0) {
> for (i = 1; i <= width; i++) {
> make_paths(dir "/dir" i, depth - 1, width, files)
> }
> }
> }
> END {make_paths(dir, depth, width, files)}
> ' </dev/null
>
> It's faster because it avoids calling seq thousands of times.
Very nice!!! I'll give that a try. Thanks!
>
>> +
>> +fill_index () {
>> + make_paths $1 $2 $3 $4 |
>> + sed "s/^/100644 $EMPTY_BLOB /" |
>
> You could add the prefix to the script above and avoid this sed call
> as well.
>
> René
>
next prev parent reply other threads:[~2017-04-06 20:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 17:38 [PATCH v5 0/4] read-cache: speed up add_index_entry git
2017-04-05 17:38 ` [PATCH v5 1/4] p0004-read-tree: perf test to time read-tree git
2017-04-06 20:20 ` René Scharfe
2017-04-06 20:41 ` Jeff Hostetler [this message]
2017-04-05 17:38 ` [PATCH v5 2/4] read-cache: add strcmp_offset function git
2017-04-06 14:19 ` SZEDER Gábor
2017-04-06 15:58 ` Jeff Hostetler
2017-04-05 17:38 ` [PATCH v5 3/4] test-strcmp-offset: created test for strcmp_offset git
2017-04-05 22:47 ` SZEDER Gábor
2017-04-06 8:21 ` Johannes Schindelin
2017-04-06 14:25 ` Jeff Hostetler
2017-04-06 20:20 ` René Scharfe
2017-04-06 20:42 ` Jeff Hostetler
2017-04-05 17:38 ` [PATCH v5 4/4] read-cache: speed up add_index_entry during checkout git
2017-04-05 22:54 ` SZEDER Gábor
2017-04-06 14:05 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6286a37f-aa22-ff70-3127-c417a6920c35@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).