From: Jeff Hostetler <git@jeffhostetler.com>
To: "René Scharfe" <l.s.r@web.de>, git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v5 3/4] test-strcmp-offset: created test for strcmp_offset
Date: Thu, 6 Apr 2017 16:42:22 -0400 [thread overview]
Message-ID: <0b27bff5-53a1-51f3-aeb4-6bd7bcd6fddc@jeffhostetler.com> (raw)
In-Reply-To: <4da78dff-7caa-b560-8af9-f5a3dfc0bed2@web.de>
On 4/6/2017 4:20 PM, René Scharfe wrote:
> Am 05.04.2017 um 19:38 schrieb git@jeffhostetler.com:
>> diff --git a/t/helper/test-strcmp-offset.c
>> b/t/helper/test-strcmp-offset.c
>> new file mode 100644
>> index 0000000..fe01318
>> --- /dev/null
>> +++ b/t/helper/test-strcmp-offset.c
>> @@ -0,0 +1,64 @@
>> +#include "cache.h"
>> +
>> +struct test_data {
>> + const char *s1;
>> + const char *s2;
>> + int first_change;
>> +};
>> +
>> +static struct test_data data[] = {
>> + { "abc", "abc", 0 },
>> + { "abc", "def", 0 },
>> +
>> + { "abc", "abz", 2 },
>> +
>> + { "abc", "abcdef", 3 },
>> +
>> + { "abc\xF0zzz", "abc\xFFzzz", 3 },
>> +
>> + { NULL, NULL, 0 }
>> +};
>> +
>> +int try_pair(const char *sa, const char *sb, int first_change)
>
> This should be static, right? Found with -Wmissing-prototypes.
right. thanks.
>
>> +{
>> + int failed = 0;
>> + int offset, r_exp, r_tst;
>> + int r_exp_sign, r_tst_sign;
>> +
>> + /*
>> + * Because differnt CRTs behave differently, only rely on signs
>
> s/differnt/different/
>
> René
next prev parent reply other threads:[~2017-04-06 20:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 17:38 [PATCH v5 0/4] read-cache: speed up add_index_entry git
2017-04-05 17:38 ` [PATCH v5 1/4] p0004-read-tree: perf test to time read-tree git
2017-04-06 20:20 ` René Scharfe
2017-04-06 20:41 ` Jeff Hostetler
2017-04-05 17:38 ` [PATCH v5 2/4] read-cache: add strcmp_offset function git
2017-04-06 14:19 ` SZEDER Gábor
2017-04-06 15:58 ` Jeff Hostetler
2017-04-05 17:38 ` [PATCH v5 3/4] test-strcmp-offset: created test for strcmp_offset git
2017-04-05 22:47 ` SZEDER Gábor
2017-04-06 8:21 ` Johannes Schindelin
2017-04-06 14:25 ` Jeff Hostetler
2017-04-06 20:20 ` René Scharfe
2017-04-06 20:42 ` Jeff Hostetler [this message]
2017-04-05 17:38 ` [PATCH v5 4/4] read-cache: speed up add_index_entry during checkout git
2017-04-05 22:54 ` SZEDER Gábor
2017-04-06 14:05 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b27bff5-53a1-51f3-aeb4-6bd7bcd6fddc@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).