* Thanks
@ 2023-11-22 18:43 Tatyana Polunin
0 siblings, 0 replies; 6+ messages in thread
From: Tatyana Polunin @ 2023-11-22 18:43 UTC (permalink / raw)
To: git
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] docs: clarify that credential discards unrecognised attributes
@ 2022-10-24 23:59 Jeff King
2022-10-25 1:51 ` Thanks M Hickford
0 siblings, 1 reply; 6+ messages in thread
From: Jeff King @ 2022-10-24 23:59 UTC (permalink / raw)
To: M Hickford via GitGitGadget; +Cc: git, M Hickford
On Mon, Oct 24, 2022 at 07:57:48AM +0000, M Hickford via GitGitGadget wrote:
> It was previously unclear how unrecognised attributes are handled.
Yeah, this was always part of the intended behavior, but I agree we did
not say it very explicitly (aside from an in-code comment!). Both the
intent and content of your patch look good to me.
We did discuss patches a long time ago that would let Git carry
arbitrary keys between helpers, even if Git itself didn't understand it.
One of the intended uses was to let helpers talk to each other about
TTLs. So if you had say:
[credential]
helper = generate-some-token
helper = cache
where the first helper generates a token, and the second caches it, the
first one could shove a "ttl" or "expiration" key into the protocol,
which the cache could then learn to respect.
But we never merged such a thing, and in practice I think people would
just implement both parts as a single helper for simplicity. And anyway,
even if we did want to do that, such a patch would want to modify the
documentation to explain the new behavior. :)
-Peff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Thanks
2022-10-24 23:59 [PATCH] docs: clarify that credential discards unrecognised attributes Jeff King
@ 2022-10-25 1:51 ` M Hickford
2022-10-25 9:05 ` Thanks Bagas Sanjaya
0 siblings, 1 reply; 6+ messages in thread
From: M Hickford @ 2022-10-25 1:51 UTC (permalink / raw)
To: peff; +Cc: git, gitgitgadget, mirth.hickford
Thanks Jeff for your reply. This is helpful to understand the background.
(first message using git send-email, hopefully I followed the instructions correctly)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Thanks
2022-10-25 1:51 ` Thanks M Hickford
@ 2022-10-25 9:05 ` Bagas Sanjaya
2022-10-26 4:39 ` Thanks M Hickford
0 siblings, 1 reply; 6+ messages in thread
From: Bagas Sanjaya @ 2022-10-25 9:05 UTC (permalink / raw)
To: M Hickford, peff; +Cc: git, gitgitgadget
On 10/25/22 08:51, M Hickford wrote:
> Thanks Jeff for your reply. This is helpful to understand the background.
>
> (first message using git send-email, hopefully I followed the instructions correctly)
You messed up the thread (you broke it).
On every message showed on lore.kernel.org/git, there is reply
instructions at the bottom of the message's page. Follow it closely.
If you insisted on either using git-send-email(1) or mailto: link
to reply, you need to manually quote any portion of original message
you wish to give the context. Make sure every line of quoted text
starts with `> `.
Better yet, reply using "reply-all" button or key in your mail client.
However, make sure your email is text/plain (not HTML) and your mail
client doesn't mess up with whitespaces (convert tabs to spaces,
word wrapping).
Thanks.
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Thanks
2022-10-25 9:05 ` Thanks Bagas Sanjaya
@ 2022-10-26 4:39 ` M Hickford
2022-10-26 5:18 ` Thanks Jeff King
2022-10-26 9:36 ` Thanks Junio C Hamano
0 siblings, 2 replies; 6+ messages in thread
From: M Hickford @ 2022-10-26 4:39 UTC (permalink / raw)
To: bagasdotme; +Cc: git, mirth.hickford
> > (first message using git send-email, hopefully I followed the instructions correctly)
>
> You messed up the thread (you broke it).
Curious. The thread overview "5+ messages" at https://lore.kernel.org/git/20221025015116.4730-1-mirth.hickford@gmail.com/#related looks okay to me. I followed the git send-email instructions setting the In-Reply-To header. I changed the subject -- maybe that confused some clients? Thanks for the tips.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Thanks
2022-10-26 4:39 ` Thanks M Hickford
@ 2022-10-26 5:18 ` Jeff King
2022-10-26 9:36 ` Thanks Junio C Hamano
1 sibling, 0 replies; 6+ messages in thread
From: Jeff King @ 2022-10-26 5:18 UTC (permalink / raw)
To: M Hickford; +Cc: bagasdotme, git
On Wed, Oct 26, 2022 at 05:39:05AM +0100, M Hickford wrote:
> > > (first message using git send-email, hopefully I followed the instructions correctly)
> >
> > You messed up the thread (you broke it).
>
> Curious. The thread overview "5+ messages" at
> https://lore.kernel.org/git/20221025015116.4730-1-mirth.hickford@gmail.com/#related
> looks okay to me. I followed the git send-email instructions setting
> the In-Reply-To header. I changed the subject -- maybe that confused
> some clients?
Your reply looked fine to me. The in-reply-to you used is correct. It's
OK to change the subject (though usually only done when the conversation
drifts to a different topic).
-Peff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Thanks
2022-10-26 4:39 ` Thanks M Hickford
2022-10-26 5:18 ` Thanks Jeff King
@ 2022-10-26 9:36 ` Junio C Hamano
1 sibling, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2022-10-26 9:36 UTC (permalink / raw)
To: M Hickford; +Cc: bagasdotme, git
M Hickford <mirth.hickford@gmail.com> writes:
>> > (first message using git send-email, hopefully I followed the instructions correctly)
>>
>> You messed up the thread (you broke it).
>
> Curious. The thread overview "5+ messages" at
> https://lore.kernel.org/git/20221025015116.4730-1-mirth.hickford@gmail.com/#related
> looks okay to me. I followed the git send-email instructions
> setting the In-Reply-To header. I changed the subject -- maybe
> that confused some clients? Thanks for the tips.
Your In-Reply-To: header looked OK to me. Some webmail platforms
break the thread when Subject: is edited, but that is their bug. As
long as you keep the In-Reply-To: chain correct, retitling the
message as necessary is indeed encouraged practice.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-22 18:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-22 18:43 Thanks Tatyana Polunin
-- strict thread matches above, loose matches on Subject: below --
2022-10-24 23:59 [PATCH] docs: clarify that credential discards unrecognised attributes Jeff King
2022-10-25 1:51 ` Thanks M Hickford
2022-10-25 9:05 ` Thanks Bagas Sanjaya
2022-10-26 4:39 ` Thanks M Hickford
2022-10-26 5:18 ` Thanks Jeff King
2022-10-26 9:36 ` Thanks Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).