From: Felipe Contreras <felipe.contreras@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org,
"brian m . carlson" <sandals@crustytoothpaste.net>,
"Martin Ågren" <martin.agren@gmail.com>,
"Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v3 3/5] doc: remove unnecessary rm instances
Date: Tue, 25 May 2021 19:24:50 -0500 [thread overview]
Message-ID: <60ad9552dd14c_2c31c2088a@natae.notmuch> (raw)
In-Reply-To: <60ad769938b70_294de208fc@natae.notmuch>
Felipe Contreras wrote:
> Junio C Hamano wrote:
> > Felipe Contreras <felipe.contreras@gmail.com> writes:
> >
> > > Junio C Hamano wrote:
> > >> Felipe Contreras <felipe.contreras@gmail.com> writes:
> > >> > * helped-by: 17% (1336)
> > >>
> > >> I actually think people use this one to say "person X gave a
> > >> valuable input in the review discussion", which is exactly the case
> > >> here, and that was why I wondered you needed to invent a completely
> > >> new one.
> > >
> > > I think the opposite: "helped-by" encompasses virtually anything...
> >
> > But your own stats disagrees with your opinion, so don't invent a
> > new thing, period.
>
> Stats don't have opinions.
Plus, here are some instances of commit trailer lines used only *once*
by big names of git.git (they are the authors).
2014-02-18: brought-to-attention-by: Junio C Hamano
2012-03-16: discussion-triggered-by: Junio C Hamano
2011-04-26: heavylifting-by: Junio C Hamano
2010-06-23: initial-fix-by: Junio C Hamano
2008-10-23: tested-on-freebsd-by: Junio C Hamano
2008-10-23: tested-on-aix-by: Junio C Hamano
2008-08-19: tested-on-mingw-by: Junio C Hamano
2008-03-23: reference: Junio C Hamano
2020-12-11: initial-patch-by: Johannes Schindelin
2020-11-19: pointed-out-by: Johannes Schindelin
2020-08-12: simplified-testcase-and-bisection-by: Elijah Newren
2020-04-27: documentation-by: Elijah Newren
2019-10-10: inspired-by-a-patch-by: Johannes Schindelin
2018-07-16: explanation-by: Stefan Beller
2018-01-04: also-reported-by: Johannes Schindelin
2017-09-23: reported-at: Jeff King
2017-01-06: test-provided-by: Stefan Beller
2016-10-07: issue-found-by: Jakub Narębski
2016-09-04: benchmarked-by: Christian Couder
2016-05-11: initial-test-by: Johannes Schindelin
2016-05-03: fix-proposed-by: Stefan Beller
2016-01-13: assisted-by: Johannes Schindelin
2016-01-12: derived-from-code-by: Johannes Schindelin
2015-09-24: history-dug-by: Jeff King
2015-09-09: reported-and-suggested-by: Johannes Schindelin
2015-06-30: clever-idea-by: Jeff King
2015-05-20: test-adapted-from: Jeff King
2015-03-03: edited-by: Stefan Beller
2014-12-12: tweaked-by: Michael Haggerty
2014-12-08: analyzed-by: Nguyễn Thái Ngọc Duy
2014-11-02: adapted-by: Nguyễn Thái Ngọc Duy
2014-06-08: reminded-by: Nguyễn Thái Ngọc Duy
2013-12-28: clarified-by: Jeff King
2013-08-21: revised-by: Shawn O. Pearce
2013-08-16: reported-and-analyzed-by: Nguyễn Thái Ngọc Duy
2013-07-09: more-spots-found-by: Jeff King
2013-02-23: brown-paper-bag-fixes-by: Jeff King
2012-10-12: initial-work-by: Nguyễn Thái Ngọc Duy
2012-07-22: reported-tested-and-explained-by: Jonathan Nieder
2011-09-22: tracked-down-by: Nguyễn Thái Ngọc Duy
2011-09-16: originally-by: Jakub Narębski
2011-04-28: inspired-by-patch-by: Jakub Narębski
2011-04-28: inspired-by-code-by: Jakub Narębski
2011-04-28: based-on-code-by: Jakub Narębski
2011-01-06: works-around: Jonathan Nieder
2011-01-02: helpd-by: Jonathan Nieder
2009-12-07: looks-fine-to-me-by: Jeff King
2009-11-11: originally-submitted-by: Jonathan Nieder
2009-05-15: looks-right-to-me-by: Johannes Schindelin
2008-12-26: patch-by: Shawn O. Pearce
2008-12-07: kind-of-noticed-by: Jakub Narębski
2008-07-03: backtraced-by: Shawn O. Pearce
2008-06-13: deemed-obviously-correct-by: Shawn O. Pearce
2008-03-29: patch-submitted-by: Eric Wong
2007-12-07: test-proposed-by: Jakub Narębski
2007-11-17: completely-acked-by: Jeff King
2007-09-12: proposed-by: Shawn O. Pearce
2007-06-03: hopefully-signed-off-by: Johannes Schindelin
2007-05-19: confirmed-by: Eric Wong
--
Felipe Contreras
next prev parent reply other threads:[~2021-05-26 0:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 22:29 [PATCH v3 0/5] doc: asciidoc cleanups Felipe Contreras
2021-05-21 22:29 ` [PATCH v3 1/5] doc: refactor common asciidoc dependencies Felipe Contreras
2021-05-21 22:29 ` [PATCH v3 2/5] doc: improve " Felipe Contreras
2021-05-21 22:29 ` [PATCH v3 3/5] doc: remove unnecessary rm instances Felipe Contreras
2021-05-24 17:51 ` Junio C Hamano
2021-05-24 18:40 ` Felipe Contreras
2021-05-24 18:45 ` Felipe Contreras
2021-05-25 2:59 ` Junio C Hamano
2021-05-25 6:54 ` Felipe Contreras
2021-05-25 17:11 ` Junio C Hamano
2021-05-25 22:13 ` Felipe Contreras
2021-05-26 0:24 ` Felipe Contreras [this message]
2021-05-21 22:29 ` [PATCH v3 4/5] doc: simplify Makefile using .DELETE_ON_ERROR Felipe Contreras
2021-05-21 22:29 ` [PATCH v3 5/5] doc: avoid using rm directly Felipe Contreras
2021-05-24 17:51 ` [PATCH v3 0/5] doc: asciidoc cleanups Junio C Hamano
2021-05-27 14:32 ` Jeff King
2021-05-27 16:59 ` Felipe Contreras
2021-05-27 17:09 ` Jeff King
2021-05-27 17:35 ` Felipe Contreras
2021-05-28 0:02 ` Junio C Hamano
2021-05-28 1:12 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60ad9552dd14c_2c31c2088a@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).