From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
"brian m . carlson" <sandals@crustytoothpaste.net>,
"Martin Ågren" <martin.agren@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Felipe Contreras" <felipe.contreras@gmail.com>
Subject: Re: [PATCH v3 0/5] doc: asciidoc cleanups
Date: Thu, 27 May 2021 10:32:27 -0400 [thread overview]
Message-ID: <YK+texFSW6UurDui@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq7djoj9z9.fsf@gitster.g>
On Tue, May 25, 2021 at 02:51:54AM +0900, Junio C Hamano wrote:
> > Documentation/Makefile | 77 ++++++++++++++++--------------------------
> > 1 file changed, 29 insertions(+), 48 deletions(-)
>
> Is this satisfactory to everybody (I haven't taken a look beyond
> comparing the end results)?
Yes, all five patches look good to me.
The "comments-by" sub-thread looked unproductive to me, so I mostly
skipped it. ;) But as the person whose name was in the trailer, I will
say that I do not care either way if it is included. It did not seem to
add anything to me. Some trailers are good for pointing later readers to
folks who may be able to help understand or debug an old commit. Some
are good for just giving credit to people who helped. "Comments-by"
didn't really seem to do either to me (and I don't feel like I
contributed much worthy of credit anyway).
-Peff
next prev parent reply other threads:[~2021-05-27 14:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 22:29 [PATCH v3 0/5] doc: asciidoc cleanups Felipe Contreras
2021-05-21 22:29 ` [PATCH v3 1/5] doc: refactor common asciidoc dependencies Felipe Contreras
2021-05-21 22:29 ` [PATCH v3 2/5] doc: improve " Felipe Contreras
2021-05-21 22:29 ` [PATCH v3 3/5] doc: remove unnecessary rm instances Felipe Contreras
2021-05-24 17:51 ` Junio C Hamano
2021-05-24 18:40 ` Felipe Contreras
2021-05-24 18:45 ` Felipe Contreras
2021-05-25 2:59 ` Junio C Hamano
2021-05-25 6:54 ` Felipe Contreras
2021-05-25 17:11 ` Junio C Hamano
2021-05-25 22:13 ` Felipe Contreras
2021-05-26 0:24 ` Felipe Contreras
2021-05-21 22:29 ` [PATCH v3 4/5] doc: simplify Makefile using .DELETE_ON_ERROR Felipe Contreras
2021-05-21 22:29 ` [PATCH v3 5/5] doc: avoid using rm directly Felipe Contreras
2021-05-24 17:51 ` [PATCH v3 0/5] doc: asciidoc cleanups Junio C Hamano
2021-05-27 14:32 ` Jeff King [this message]
2021-05-27 16:59 ` Felipe Contreras
2021-05-27 17:09 ` Jeff King
2021-05-27 17:35 ` Felipe Contreras
2021-05-28 0:02 ` Junio C Hamano
2021-05-28 1:12 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK+texFSW6UurDui@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).