From: Patrick Hemmer <git@stormcloud9.net>
To: git@vger.kernel.org
Subject: Bug: format-patch MIME boundary not added to cover letter when attach enabled
Date: Sun, 29 Apr 2018 21:40:13 -0400 [thread overview]
Message-ID: <5e409069-835f-3c85-f55e-c27f534dc9e2@stormcloud9.net> (raw)
When you use `git format-patch --cover-letter --attach`, the cover
letter does not have the trailing MIME boundary. RFC2046 states that the
last part must be followed by a closing boundary. This causes some email
clients (Thunderbird in my case) to discard the message body.
This is experienced with git 2.16.3.
For example:
$ git format-patch --cover-letter --attach --root -o /tmp/out
/tmp/out/0000-cover-letter.patch
/tmp/out/0001-hello-world.patch
$ cat /tmp/out/0000-cover-letter.patch
From a25ac88e6216131e8b000335d32bb99d4e5185ac Mon Sep 17 00:00:00 2001
From: Patrick Hemmer <git@stormcloud9.net>
Date: Sun, 29 Apr 2018 21:26:45 -0400
Subject: [PATCH 0/1] *** SUBJECT HERE ***
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------2.16.3"
This is a multi-part message in MIME format.
--------------2.16.3
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit
*** BLURB HERE ***
Patrick Hemmer (1):
hello world
--
2.16.3
next reply other threads:[~2018-04-30 1:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 1:40 Patrick Hemmer [this message]
2018-04-30 2:09 ` Bug: format-patch MIME boundary not added to cover letter when attach enabled brian m. carlson
2018-04-30 3:30 ` Junio C Hamano
2018-04-30 11:59 ` brian m. carlson
2018-05-01 0:02 ` [PATCH] format-patch: make cover letters always text/plain brian m. carlson
2018-05-01 1:53 ` Eric Sunshine
2018-05-02 0:16 ` brian m. carlson
2018-05-02 2:20 ` [PATCH v2] " brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e409069-835f-3c85-f55e-c27f534dc9e2@stormcloud9.net \
--to=git@stormcloud9.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).