From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Patrick Hemmer <git@stormcloud9.net>, git@vger.kernel.org
Subject: Re: Bug: format-patch MIME boundary not added to cover letter when attach enabled
Date: Mon, 30 Apr 2018 11:59:09 +0000 [thread overview]
Message-ID: <20180430115909.GB13217@genre.crustytoothpaste.net> (raw)
In-Reply-To: <xmqqzi1lxte6.fsf@gitster-ct.c.googlers.com>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Mon, Apr 30, 2018 at 12:30:57PM +0900, Junio C Hamano wrote:
> Thanks. It is true that the current output from the tool is corrupt
> mime multi-part, and we need to do something about it.
>
> I however have to wonder if it even makes sense for --cover to pay
> attention to --attach and produce the cover template that has "BLURB
> HERE" etc. in a multi-part format. Shouldn't we be making a simple
> plain text file instead?
I agree that multipart/mixed is not a useful content-type for only one
plain text part. I have a patch to add the trailing boundary, but I
think you make a good argument that perhaps omitting the entire
multipart portion would be better.
I'll have to work on this after work, so expect a patch later today.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]
next prev parent reply other threads:[~2018-04-30 11:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 1:40 Bug: format-patch MIME boundary not added to cover letter when attach enabled Patrick Hemmer
2018-04-30 2:09 ` brian m. carlson
2018-04-30 3:30 ` Junio C Hamano
2018-04-30 11:59 ` brian m. carlson [this message]
2018-05-01 0:02 ` [PATCH] format-patch: make cover letters always text/plain brian m. carlson
2018-05-01 1:53 ` Eric Sunshine
2018-05-02 0:16 ` brian m. carlson
2018-05-02 2:20 ` [PATCH v2] " brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430115909.GB13217@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@stormcloud9.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).