From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Wolfgang Denk <wd@denx.de>,
git@vger.kernel.org
Subject: Re: git error in tag ...: unterminated header
Date: Sat, 27 Jun 2015 10:57:23 +0200 [thread overview]
Message-ID: <5bf3e78138813d8667f4761cc7bc23a3@www.dscho.org> (raw)
In-Reply-To: <xmqqh9puv0a8.fsf@gitster.dls.corp.google.com>
Hi Junio,
On 2015-06-26 19:37, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
>> On Fri, Jun 26, 2015 at 10:06:20AM +0200, Johannes Schindelin wrote:
>>
>>> I understood what you were saying, but it still appears too fragile to
>>> me to mix functions that assume NUL-terminated strings with an ad-hoc
>>> counted string check.
>>
>> Yeah, I agree. It is not that you cannot make it safe, but that it is
>> simply a fragile maintenance burden in the future. I thought we dealt
>> with this already with a1e920a (index-pack: terminate object buffers
>> with NUL, 2014-12-08), though.
>
> Hmph, that is an interesting point.
>
> It would mean that the require_eoh() can be reduced a bit further.
>
> * It is still a good idea to make sure we do not have NUL in the
> header part,
>
> * It can still stop scanning when it finds a blank line (i.e. we do
> not care what is in the message part of commit and tag),
>
> * It does not have to insist that a commit or a tag has a blank
> line to reject a header-only object.
>
> That would mean the name of the helper needs to change, though.
You mean in addition to your changes to read new lines only when we're still inside the buffer? I cannot say that I like this fragility (and would prefer the aforementioned patch that simply allocates a NUL-terminated buffer in the rather unlikely event of tag/commit objects without an empty line), but then: you are stuck with maintaining this code, so it is your decision. ;-)
I will hopefully have time starting Tuesday this week to work on that patch, if nobody else beats me to it.
Ciao,
Dscho
next prev parent reply other threads:[~2015-06-27 8:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 15:51 git error in tag ...: unterminated header Wolfgang Denk
2015-06-25 17:32 ` Junio C Hamano
2015-06-25 20:13 ` Wolfgang Denk
2015-06-25 20:24 ` Junio C Hamano
2015-06-25 21:07 ` Johannes Schindelin
2015-06-25 21:21 ` Junio C Hamano
2015-06-25 22:29 ` Junio C Hamano
2015-06-26 8:06 ` Johannes Schindelin
2015-06-26 15:52 ` Jeff King
2015-06-26 17:37 ` Junio C Hamano
2015-06-27 8:57 ` Johannes Schindelin [this message]
2015-06-27 18:36 ` Junio C Hamano
2015-06-28 18:18 ` [PATCH] fsck: it is OK for a tag and a commit to lack the body Junio C Hamano
2015-06-28 18:21 ` Eric Sunshine
2015-06-29 5:12 ` Johannes Schindelin
2015-06-29 5:42 ` Junio C Hamano
2015-06-29 14:51 ` Johannes Schindelin
2015-06-25 20:48 ` git error in tag ...: unterminated header Junio C Hamano
2015-06-25 17:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bf3e78138813d8667f4761cc7bc23a3@www.dscho.org \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).