From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Wolfgang Denk <wd@denx.de>,
git@vger.kernel.org
Subject: Re: [PATCH] fsck: it is OK for a tag and a commit to lack the body
Date: Mon, 29 Jun 2015 07:12:38 +0200 [thread overview]
Message-ID: <32aa1979e75ba9bc6dc8a58fe32e9e55@www.dscho.org> (raw)
In-Reply-To: <xmqqlhf3elxk.fsf_-_@gitster.dls.corp.google.com>
Hi Junio,
On 2015-06-28 20:18, Junio C Hamano wrote:
> diff --git a/fsck.c b/fsck.c
> index 88c92e8..3f264e7 100644
> --- a/fsck.c
> +++ b/fsck.c
> @@ -255,6 +255,15 @@ static int require_end_of_header(const void
> *data, unsigned long size,
> }
> }
>
> + /*
> + * We did not find double-LF that separates the header
> + * and the body. Not having a body is not a crime but
> + * we do want to see the terminating LF for the last header
> + * line.
> + */
> + if (size && buffer[size - 1] == '\n')
> + return 0;
> +
> return error_func(obj, FSCK_ERROR, "unterminated header");
> }
>
Hmm. Maybe we should still warn when there is no empty line finishing the header explicitly, or at least make it FSCK_IGNORE by default so that maintainers who like a stricter check can upgrade the condition to an error?
Otherwise: ACK.
Ciao,
Dscho
next prev parent reply other threads:[~2015-06-29 5:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 15:51 git error in tag ...: unterminated header Wolfgang Denk
2015-06-25 17:32 ` Junio C Hamano
2015-06-25 20:13 ` Wolfgang Denk
2015-06-25 20:24 ` Junio C Hamano
2015-06-25 21:07 ` Johannes Schindelin
2015-06-25 21:21 ` Junio C Hamano
2015-06-25 22:29 ` Junio C Hamano
2015-06-26 8:06 ` Johannes Schindelin
2015-06-26 15:52 ` Jeff King
2015-06-26 17:37 ` Junio C Hamano
2015-06-27 8:57 ` Johannes Schindelin
2015-06-27 18:36 ` Junio C Hamano
2015-06-28 18:18 ` [PATCH] fsck: it is OK for a tag and a commit to lack the body Junio C Hamano
2015-06-28 18:21 ` Eric Sunshine
2015-06-29 5:12 ` Johannes Schindelin [this message]
2015-06-29 5:42 ` Junio C Hamano
2015-06-29 14:51 ` Johannes Schindelin
2015-06-25 20:48 ` git error in tag ...: unterminated header Junio C Hamano
2015-06-25 17:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32aa1979e75ba9bc6dc8a58fe32e9e55@www.dscho.org \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).