* [PATCH] gitweb: fix base url set if PATH_INFO is used, add a / at the end.
@ 2023-02-03 21:42 Daniel Abrecht
2023-02-06 22:02 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Abrecht @ 2023-02-03 21:42 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano
In HTML, if there is a base tag like `<base href="/a/b">`,
a relative URL like `c/d` will be resolved by the browser as
`a/c/d` and not as `a/b/c/d`. But with a base tag like
`<base href="/a/b/">` it will result in `a/b/c/d`. So by
adding a slash there, the browser should now search the
files at the correct location.
Signed-off-by: Daniel Abrecht <public@danielabrecht.ch>
---
gitweb/gitweb.perl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index e66eb3d9ba..acb2cce5f6 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4217,7 +4217,7 @@ sub git_header_html {
# the stylesheet, favicon etc urls won't work correctly with path_info
# unless we set the appropriate base URL
if ($ENV{'PATH_INFO'}) {
- print "<base href=\"".esc_url($base_url)."\" />\n";
+ print "<base href=\"".esc_url($base_url)."/\" />\n";
}
print_header_links($status);
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gitweb: fix base url set if PATH_INFO is used, add a / at the end.
2023-02-03 21:42 [PATCH] gitweb: fix base url set if PATH_INFO is used, add a / at the end Daniel Abrecht
@ 2023-02-06 22:02 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2023-02-06 22:02 UTC (permalink / raw)
To: Daniel Abrecht; +Cc: git
Daniel Abrecht <git-git@nodmarc.danielabrecht.ch> writes:
> In HTML, if there is a base tag like `<base href="/a/b">`,
> a relative URL like `c/d` will be resolved by the browser as
> `a/c/d` and not as `a/b/c/d`. But with a base tag like
> `<base href="/a/b/">` it will result in `a/b/c/d`. So by
> adding a slash there, the browser should now search the
> files at the correct location.
>
> Signed-off-by: Daniel Abrecht <public@danielabrecht.ch>
> ---
> gitweb/gitweb.perl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index e66eb3d9ba..acb2cce5f6 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -4217,7 +4217,7 @@ sub git_header_html {
> # the stylesheet, favicon etc urls won't work correctly with path_info
> # unless we set the appropriate base URL
> if ($ENV{'PATH_INFO'}) {
> - print "<base href=\"".esc_url($base_url)."\" />\n";
> + print "<base href=\"".esc_url($base_url)."/\" />\n";
Doesn't this need to be somewhat conditional? Sites like repo.or.cz
currently give <base href="/" /> presumably because $base_url for
them is '/', and this change will make them show double slashes
instead of a single one, no?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-06 22:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-03 21:42 [PATCH] gitweb: fix base url set if PATH_INFO is used, add a / at the end Daniel Abrecht
2023-02-06 22:02 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).