From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Elia Pinto <gitter.spiros@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 07/10] t5100-mailinfo.sh: use the $( ... ) construct for command substitution
Date: Mon, 28 Dec 2015 08:44:20 +0100 [thread overview]
Message-ID: <5680E854.7050001@kdbg.org> (raw)
In-Reply-To: <xmqq37unbaff.fsf@gitster.mtv.corp.google.com>
Am 28.12.2015 um 02:59 schrieb Junio C Hamano:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Very true. Let's leave that kind of things as separate clean-ups
>> after these patches settle, as mixing manual and mechanical changes
>> in a single patch makes it harder to review.
>>
>> Thanks.
>
> So that I won't forget (I'll need to amend with your sign-off even
> if this one is satisfactory to you).
>
> -- >8 --
> From: Johannes Sixt <j6t@kdbg.org>
> Date: Tue, 22 Dec 2015 19:35:16 +0100
> Subject: [PATCH] t5100: no need to use 'echo' command substitutions for globbing
>
> Instead of making the shell expand 00* and invoke 'echo' with it,
> and then capturing its output as command substitution, just use
> the result of expanding 00* directly.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> t/t5100-mailinfo.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t5100-mailinfo.sh b/t/t5100-mailinfo.sh
> index 4e52b3b..85b3df5 100755
> --- a/t/t5100-mailinfo.sh
> +++ b/t/t5100-mailinfo.sh
> @@ -23,7 +23,7 @@ check_mailinfo () {
> }
>
>
> -for mail in $(echo 00*)
> +for mail in 00*
> do
> test_expect_success "mailinfo $mail" '
> check_mailinfo $mail "" &&
> @@ -51,7 +51,7 @@ test_expect_success 'split box with rfc2047 samples' \
> echo total is $last &&
> test $(cat rfc2047/last) = 11'
>
> -for mail in $(echo rfc2047/00*)
> +for mail in rfc2047/00*
> do
> test_expect_success "mailinfo $mail" '
> git mailinfo -u $mail-msg $mail-patch <$mail >$mail-info &&
>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Thank you for making a proper patch!
-- Hannes
next prev parent reply other threads:[~2015-12-28 7:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 15:27 [PATCH 00/10] use the $( ... ) construct for command substitution Elia Pinto
2015-12-22 15:27 ` [PATCH 01/10] t3101-ls-tree-dirname.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 02/10] t3210-pack-refs.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 03/10] t3403-rebase-skip.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 04/10] t3511-cherry-pick-x.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 05/10] t3600-rm.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 06/10] t3700-add.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 07/10] t5100-mailinfo.sh: " Elia Pinto
2015-12-22 18:35 ` Johannes Sixt
2015-12-22 20:34 ` Johannes Sixt
2015-12-27 23:46 ` Junio C Hamano
2015-12-28 1:59 ` Junio C Hamano
2015-12-28 7:44 ` Johannes Sixt [this message]
2015-12-22 15:27 ` [PATCH 08/10] t5300-pack-object.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 09/10] t5301-sliding-window.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 10/10] t5302-pack-index.sh: " Elia Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5680E854.7050001@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitter.spiros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).