From: Elia Pinto <gitter.spiros@gmail.com>
To: git@vger.kernel.org
Cc: Elia Pinto <gitter.spiros@gmail.com>
Subject: [PATCH 07/10] t5100-mailinfo.sh: use the $( ... ) construct for command substitution
Date: Tue, 22 Dec 2015 16:27:50 +0100 [thread overview]
Message-ID: <1450798073-22811-8-git-send-email-gitter.spiros@gmail.com> (raw)
In-Reply-To: <1450798073-22811-1-git-send-email-gitter.spiros@gmail.com>
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
t/t5100-mailinfo.sh | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/t/t5100-mailinfo.sh b/t/t5100-mailinfo.sh
index e97cfb2..4e52b3b 100755
--- a/t/t5100-mailinfo.sh
+++ b/t/t5100-mailinfo.sh
@@ -9,9 +9,9 @@ test_description='git mailinfo and git mailsplit test'
test_expect_success 'split sample box' \
'git mailsplit -o. "$TEST_DIRECTORY"/t5100/sample.mbox >last &&
- last=`cat last` &&
+ last=$(cat last) &&
echo total is $last &&
- test `cat last` = 17'
+ test $(cat last) = 17'
check_mailinfo () {
mail=$1 opt=$2
@@ -23,7 +23,7 @@ check_mailinfo () {
}
-for mail in `echo 00*`
+for mail in $(echo 00*)
do
test_expect_success "mailinfo $mail" '
check_mailinfo $mail "" &&
@@ -47,11 +47,11 @@ test_expect_success 'split box with rfc2047 samples' \
'mkdir rfc2047 &&
git mailsplit -orfc2047 "$TEST_DIRECTORY"/t5100/rfc2047-samples.mbox \
>rfc2047/last &&
- last=`cat rfc2047/last` &&
+ last=$(cat rfc2047/last) &&
echo total is $last &&
- test `cat rfc2047/last` = 11'
+ test $(cat rfc2047/last) = 11'
-for mail in `echo rfc2047/00*`
+for mail in $(echo rfc2047/00*)
do
test_expect_success "mailinfo $mail" '
git mailinfo -u $mail-msg $mail-patch <$mail >$mail-info &&
--
2.3.3.GIT
next prev parent reply other threads:[~2015-12-22 15:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 15:27 [PATCH 00/10] use the $( ... ) construct for command substitution Elia Pinto
2015-12-22 15:27 ` [PATCH 01/10] t3101-ls-tree-dirname.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 02/10] t3210-pack-refs.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 03/10] t3403-rebase-skip.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 04/10] t3511-cherry-pick-x.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 05/10] t3600-rm.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 06/10] t3700-add.sh: " Elia Pinto
2015-12-22 15:27 ` Elia Pinto [this message]
2015-12-22 18:35 ` [PATCH 07/10] t5100-mailinfo.sh: " Johannes Sixt
2015-12-22 20:34 ` Johannes Sixt
2015-12-27 23:46 ` Junio C Hamano
2015-12-28 1:59 ` Junio C Hamano
2015-12-28 7:44 ` Johannes Sixt
2015-12-22 15:27 ` [PATCH 08/10] t5300-pack-object.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 09/10] t5301-sliding-window.sh: " Elia Pinto
2015-12-22 15:27 ` [PATCH 10/10] t5302-pack-index.sh: " Elia Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450798073-22811-8-git-send-email-gitter.spiros@gmail.com \
--to=gitter.spiros@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).