From: "Torsten Bögershausen" <tboegi@web.de>
To: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Cc: Stefan Beller <stefanbeller@gmail.com>, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 3/3] format-patch: check that header line has expected format
Date: Mon, 14 Dec 2015 08:16:47 +0100 [thread overview]
Message-ID: <566E6CDF.3020004@web.de> (raw)
In-Reply-To: <1450027638-788102-4-git-send-email-sandals@crustytoothpaste.net>
On 13.12.15 18:27, brian m. carlson wrote:
> The format of the "From " header line is very specific to allow
> utilities to detect Git-style patches. Add a test that the patches
> created are in the expected format.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
> t/t4014-format-patch.sh | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
> index b740e3da..362bc228 100755
> --- a/t/t4014-format-patch.sh
> +++ b/t/t4014-format-patch.sh
> @@ -1437,4 +1437,10 @@ test_expect_success 'format-patch --zero-commit' '
> test $cnt = 3
> '
>
> +test_expect_success 'From line has expected format' '
> + git format-patch --stdout v2..v1 >patch2 &&
> + cnt=$(egrep "^From [0-9a-f]{40} Mon Sep 17 00:00:00 2001" patch2 | wc -l) &&
> + test $cnt = 3
For these kind of things:
test_line_count() is your friend
next prev parent reply other threads:[~2015-12-14 7:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 17:27 [PATCH v2 0/3] format-patch: introduce option to suppress commit hashes brian m. carlson
2015-12-13 17:27 ` [PATCH v2 1/3] Introduce a null_oid constant brian m. carlson
2015-12-13 17:27 ` [PATCH v2 2/3] format-patch: add an option to suppress commit hash brian m. carlson
2015-12-14 21:43 ` Junio C Hamano
2015-12-13 17:27 ` [PATCH v2 3/3] format-patch: check that header line has expected format brian m. carlson
2015-12-14 7:16 ` Torsten Bögershausen [this message]
2015-12-14 19:11 ` Junio C Hamano
2015-12-14 21:45 ` Junio C Hamano
2015-12-14 21:32 ` [PATCH v2 0/3] format-patch: introduce option to suppress commit hashes Jeff King
2015-12-15 0:35 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566E6CDF.3020004@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=stefanbeller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).