From: Jeff King <peff@peff.net>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Stefan Beller <stefanbeller@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 0/3] format-patch: introduce option to suppress commit hashes
Date: Mon, 14 Dec 2015 16:32:39 -0500 [thread overview]
Message-ID: <20151214213239.GH14788@sigill.intra.peff.net> (raw)
In-Reply-To: <1450027638-788102-1-git-send-email-sandals@crustytoothpaste.net>
On Sun, Dec 13, 2015 at 05:27:15PM +0000, brian m. carlson wrote:
> git format-patch is often used to create patches that are then stored in
> version control or displayed with diff. Having the commit hash in the
> "From " line usually just creates diff noise in these cases, so this
> series introduces --zero-commit to set that to all zeros.
>
> Changes from v1:
> * Rename the option --zero-commit.
> * Improve the tests to look for a 40-hex hash value in "From " header.
>
> brian m. carlson (3):
> Introduce a null_oid constant.
> format-patch: add an option to suppress commit hash
> format-patch: check that header line has expected format
The intent here makes sense to me, and with the exception of the
test_line_count thing that Torsten mentioned, the code looks good.
I briefly wondered if the option should simply be "--diffable" or
something like that, and trigger this new behavior as well as implying
--no-signature. Along with any other relevant options (if any; I don't
recall if --stat-width is terminal-dependent for format-patch, for
example).
But that is probably overkill. People can flip those switches
individually if they want to (and even if somebody did want
"--diffable", it may make sense to build it on top, so they can flip the
zero-commit thing individually if they want).
-Peff
next prev parent reply other threads:[~2015-12-14 21:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 17:27 [PATCH v2 0/3] format-patch: introduce option to suppress commit hashes brian m. carlson
2015-12-13 17:27 ` [PATCH v2 1/3] Introduce a null_oid constant brian m. carlson
2015-12-13 17:27 ` [PATCH v2 2/3] format-patch: add an option to suppress commit hash brian m. carlson
2015-12-14 21:43 ` Junio C Hamano
2015-12-13 17:27 ` [PATCH v2 3/3] format-patch: check that header line has expected format brian m. carlson
2015-12-14 7:16 ` Torsten Bögershausen
2015-12-14 19:11 ` Junio C Hamano
2015-12-14 21:45 ` Junio C Hamano
2015-12-14 21:32 ` Jeff King [this message]
2015-12-15 0:35 ` [PATCH v2 0/3] format-patch: introduce option to suppress commit hashes brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214213239.GH14788@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
--cc=stefanbeller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).